Currently mp_product_kit is non-functional, there are various errors, the first of which is #1702078: enabling 'Marketplace Product Kit' gives an error Once that is fixed it's downhill again.

This patch gets mp_product_kit working and should have implemented all the TODO's that are currently in mp_product_kit.

I'm not sure if there have been other changes in UC or MP which would require additional functionality which was not already covered by mp_product_kit in Drupal 6.

Fixes:

  • Database query now respects the node access rights.
  • Calculations should be correct for validating the price of the product kit against MP's admin base price.
  • Incorrect hook invoked (product_types should be uc_product_types).
  • Old hook_nodeapi updated to hook_node_validate.
  • Add handling of whether a product kit is mutable or not in the validation calculations.
  • Security, .info and other minor fixes.

Please review and let me know if anything is amiss.

CommentFileSizeAuthor
ubercart_marketplace-port-mp_product_kit.patch5.25 KBphizes

Comments

PatchRanger’s picture

PatchRanger commented

Please keep in mind that fixing this issue is going to be rewarded by not less than $9: see "9$ bounty just for reviewing a patch for Ubercart Marketplace module" for reference.

OliveIT’s picture

OliveIT commented
Issue summary: View changes

Cannot get this patch to apply. Says cannot find file at line 15.

OliveIT’s picture

OliveIT commented

Okay, after editing the target file paths to absolute paths it could find the files and did indeed patch them. The patch does work minus this issue and all issues above seem to be resolved from brief testing. This patch should be pushed into the main branch so that it will update the latest download to include this patch as it fixes the above errors properly.

OliveIT’s picture

OliveIT commented
Status: Needs review » Reviewed & tested by the community

Please push into main branch for 7.x version.