Download & Extend
Drupal Commons » Issues

Save comment error when following post content type.

Posted by Topcheese on October 15, 2012 at 8:06am
Project:Drupal Commons
Version:7.x-3.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Admin following and commenting on own post. Saves fine when you unfollow.
MessageNotifyException: Field field_message_rendered_subject does not exist. in MessageNotifierBase->postSend() (line 123 of C:\xampp\htdocs\profiles\commons\modules\contrib\message_notify\plugins\notifier\abstract.inc).

Login or register to post comments

Comments

#1

Posted by ezra-g on November 10, 2012 at 4:55pm
Status:active» fixed

Please re-open if this happens with the latest nightly dev snapshot.

#2

Posted by Topcheese on November 10, 2012 at 6:14pm
Status:fixed» active
  1. Admin creates a post type content
  2. Admin selects to follow the content
  3. the above error when admin comments on it
  4. Admin can leave comment if not following.
  • Commons 7.x-3.x-dev rel. 09 Nov 2012
  • Win7 Home Premium
  • Apache 2.4.3
  • MySql 5.5.27
  • PHP 5.4.7
  • Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20100101 Firefox/16.0

#3

Posted by ezra-g on November 18, 2012 at 2:03am
Version:7.x-3.0-alpha1» 7.x-3.x-dev
Status:active» postponed (maintainer needs more info)

Moving the version to dev based on #1/2.

Sorry, but I'm still not able to reproduce but let's see if we can figure this out.

Does the error persist after you revert all the Features on the site and make sure that the message_notify_example module is disabled?

#4

Posted by Topcheese on November 18, 2012 at 7:12am

Now they aren't saving at all and I get no visible error message. I've changed my dev environment around a bit since, and I'm still working that out, but I can still test this on the old setup.

IIS 7.5
PHP 5.3
MySQL 5.1

What I'm getting now in the error logs is this.

Notice: Trying to get property of non-object in commons_radioactivity_flag() (line 12 of C:\inetpub\wwwroot\profiles\commons\modules\contrib\commons_radioactivity\includes\incidents\commons_radioactivity.incidents_flag.inc).
Notice: Undefined variable: node in commons_radioactivity_flag() (line 15 of C:\inetpub\wwwroot\profiles\commons\modules\contrib\commons_radioactivity\includes\incidents\commons_radioactivity.incidents_flag.inc).

http://devmachine.dev/flag/flag/commons_follow_node/17?destination=node/...
Notice: Trying to get property of non-object in commons_radioactivity_incident_node() (line 50 of C:\inetpub\wwwroot\profiles\commons\modules\contrib\commons_radioactivity\commons_radioactivity.module).

#5

Posted by ezra-g on November 18, 2012 at 3:12pm

I've changed my dev environment around a bit since, and I'm still working that out, but I can still test this on the old setup.

For reference, are you able to reproduce these errors on a fresh installation of the latest alpha or nightly dev snapshot?

#6

Posted by Topcheese on November 18, 2012 at 10:03pm

Same problem on original setup. Error message when following and commenting on a post. If you unfollow, then you can save a comment. I will try with today's build.

#7

Posted by Topcheese on November 19, 2012 at 12:14am

This one is tied to several issues and not saving the comment, but first let me explain the installation. I download the zip, extract it in web root, then I install it TTW. I just started getting this new issue which I thought was related to IIS, but I'm also now getting on Nix/Apache.

One or more CSS files were not found or does not exist public://adaptivetheme/commons_origins_files/commons_origins.lt-ie9.layout.css

I resolved it by going into theme administration settings, and then selecting CSS from the menu on left. Change the default theme generation option from public to theme directory. I'm still having the following related issues.

#8

Posted by Topcheese on November 19, 2012 at 7:54pm
Priority:normal» critical
Status:postponed (maintainer needs more info)» active

This is obviously a serious matter. Here is another issue posted. Comments are not saved

#9

Posted by Pierre Paul Lefebvre on November 25, 2012 at 5:47pm

The commons_notify module tries to send an e-mail to everyone following the group (not just the admin posting+following the comment).

The commons_notify tries to create the email giving the entity type : commons_notify_comment_created.
This entity type doesn't seem to be defined anywhere.
Maybe someone forgot to export a feature or something?

PS. I dont know how comment #7 is related to this bug.
PS2. Doesn't have anything to do with PHP or Apache/IIS.

#10

Posted by codexmas on November 25, 2012 at 6:02pm

Following up on Pierre's comment the only occurrence of this content type being mentioned is in:
profiles/commons/modules/contrib/commons_activity_streams/commons_activity_streams.module:106

/**
* Implements hook_commons_notify_message_type_mapping_alter().
*/
function commons_activity_streams_commons_notify_message_type_mapping_alter(&$mapping) {
  $cas_mapping = array(
    'commons_activity_streams_comment_created' => 'commons_notify_comment_created',
  );
  $mapping = array_merge($mapping, $cas_mapping);
}

Perhaps as suggested there are some files that aren't committed yet?

Cheers,
Gord.

#11

Posted by ezra-g on November 25, 2012 at 6:38pm
Status:active» fixed

The Commons Notify module is being refactored to use Message Subscribe as part of #1834946: Implement email notifications & UI with Message Subscribe. I just committed the latest progress towards that work, which I believe resolves this error. Please re-open if it persists after doing a git pull on Commons Notify.

http://drupalcode.org/project/commons_notify.git/commit/9c8c3fb

#12

Posted by Pierre Paul Lefebvre on November 26, 2012 at 12:07am

It works! Thanks Ezra!

#13

Posted by System Message on December 10, 2012 at 12:10am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.