Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
configuration system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Oct 2012 at 18:07 UTC
Updated:
29 Jul 2014 at 21:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
linl commentedFirst stab at converting to config - here's a patch.
Comment #3
linl commentedComment #4
linl commentedIncluded in user.settings.yml instead of a separate yml.
Comment #5
berdirDo we want to extend the existing generic user.settings update function to include this instead of adding another one?
8.x -> 8.x updates aren't supported and this is just an internal setting without UI that nobody has set to something else (in 8.x at least ;)) anyway.
Would avoid adding another one that could possibly conflict with other issues.
Comment #6
gddI don't know, update settings conflicts are par for the course, and I can't remember a time when we've added stuff into existing update functions like that before? I'd rather just get this in and move on. I looked it over and otherwise it looks good, so lets go!
Comment #7
berdir@heyrocker #1807266: Convert user_cancel_method variable to CMI system does exactly that, that's why I suggested it.
Anyway, getting this in like this is fine with me as well.
Comment #8
webchickActually, I agree it'd be nice to group like-updates together in the same update function. Can we get a quick re-roll for that? Feel free to mark back to RTBC after; as long as testbot says it's good, I can commit it.
Comment #9
linl commentedRe-rolled to remove extra update function.
Comment #10
berdirThanks, back to RTBC then, as webchick requested.
Comment #11
webchickLooks like this needs a quick re-roll.
Comment #12
linl commentedComment #13
berdirAnd back to RTBC again.
Comment #15
linl commented#12: user_password_reset_timeout-1814558-12.patch queued for re-testing.
Comment #16
linl commentedBack to RTBC.
Comment #17
dries commentedCommitted to 8.x. Thanks.