MediaCore

Hi,

You are still working on the master branch, please look how to create and name git branches.

Automatic review

There are too many errors on the automatic review, please find and correct this before other reviews.
http://ventral.org/pareview/httpgitdrupalorgsandboxmediacore1708680git

README.txt

readme.txt file should be renamed as README.txt

Manual review

Master branch

You are working on master branch, please switch to a 7.x-1.x branch and delete the master.

mediacoreinsert.file:

You can remove all this.

files[] = 
; Information added by drupal.org packaging script on 2012-01-11
version = "7.x-1.0"
core = "7.x"
project = "mediacoreinsert"
datestamp = "1326312349

"

mediacoreinsert.module

There many are security issues!
1. The $_GET parameters are printed on the template without checking its values. Please check all dynamic urls with check_url() (like $variables['next'] and ['previous']).
Verify that all entered data from users that is shown on the template has been sanitized.
You can have more info on this page: http://drupal.org/node/28984

2. You shouldn't create forms on the template to prevent against CSRF attacks. Use Form API instead.

You are creating variables that are not deleted. Those should be erased on using hook_uninstall() on an .install file with variable_del();

mediacoreinsert_dashboard.tpl.php

Declaring functions inside a tpl.php is not the standard way.
Please send variables to the template instead using hook_preprocess_HOOK().

Is this REALLY necessary ? :-) Please remove...

/**
 *       __  _____________   _______   __________  ____  ______
 *      /  |/  / ____/ __ \ /  _/   | / ____/ __ \/ __ \/ ____/
 *     / /|_/ / __/ / / / / / // /| |/ /   / / / / /_/ / __/   
 *    / /  / / /___/ /_/ /_/ // ___ / /___/ /_/ / _, _/ /___   
 *   /_/  /_/_____/_____//___/_/  |_\____/\____/_/ |_/_____/   
 *                        WYSIWYG Plugin
 *
 *
 */

Closing due to lack of activity. Feel free to reopen if you are still working on this application.