The Twitter Sign-In module should use url() to print the correct link to user/<uid>/edit.

CommentFileSizeAuthor
#3 twitter_signin-1814618-3-use_l.patch845 bytesxurizaemon
#1 1814618-use-url.patch640 bytesfizk

Comments

fizk’s picture

fizk commented
StatusFileSize
new 1814618-use-url.patch640 bytes

Here's a patch.

fizk’s picture

fizk commented
Status: Active » Needs review
xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Fixed » Needs review
StatusFileSize
new twitter_signin-1814618-3-use_l.patch845 bytes

Trivial but probably should use l() instead?

I'm not particularly keen on printing the generated password to the screen as we do in twitter_signin_oauth_callback_submit(), but that's another issue: #1816278: Registering account via Twitter Signon should not display the password

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Needs review » Fixed

Oh rubbish, I unintentionally rolled this into a trivial docfix. Apologies. Issue fixed now.

http://drupalcode.org/project/twitter.git/commit/75fb334

Status: Needs review » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Component: Code » Twitter Signin
anacolautti’s picture

anacolautti commented
Version: 7.x-3.x-dev » 7.x-5.x-dev
Issue summary: View changes
Status: Closed (fixed) » Active

Hello there! The patch from #2 makes the string untranslatable. According to the l() documentation, the correct way to implement it was like the patch in #1.

Can we please roll back to #1? Do you need a new patch? We can definitively provide you with one. Thanks

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Active » Closed (fixed)

Since this was committed two years ago to 7.x-3.x and we're currently developing for 7.x-6.x, please report a new issue and supply a patch there. Do reference the previous commit & issue in that one. Thanks!