If a CAS user tries to log in and there's no account found, shouldn't the message get the class .error or .warning instead of just .status (which is displayed with positive visual language in most themes.)

"No Account Found" is green with a checkmark next to it.

CommentFileSizeAuthor
#1 1814748-1.patch543 bytesbfroehle
no-account-found.png4.52 KBliquid06

Comments

bfroehle’s picture

bfroehle commented
Version: 7.x-1.2 » 7.x-1.x-dev
Priority: Minor » Normal
Status: Active » Needs review
StatusFileSize
new 1814748-1.patch543 bytes

I think .error seems appropriate.

bfroehle’s picture

bfroehle commented
Component: Miscellaneous » CAS
liquid06’s picture

liquid06 commented

Wow thanks! I tested the patch and didn't run into any problems - it seems a lot better for alerting the person signing in that there's a problem. Is the protocol that more people have to test before marking rtbc, or is this small enough that one tester is enough? :)

bfroehle’s picture

bfroehle commented
Status: Needs review » Fixed

Committed to 6.x-3.x and 7.x-1.x. Thanks for the report.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 22b2a35 on 7.x-1.x, 8.x-1.x by bfroehle: 
    Issue #1814748 by bfroehle | liquid06: Fixed 'No Account Found" message...