D7 api: dblog_cron()
"Remove expired log messages and flood control events."

I do not see in the code that flood control events are deleted.. I guess that part of the sentence should be removed.

Comments

Anonymous’s picture

Version: 7.x-dev » 8.x-dev

Is this report valid for D8?

jhodgdon’s picture

Version: 8.x-dev » 7.x-dev
Issue tags: +Needs backport to D6

What are flood control events anyway? Oh I see... In Drupal 5, the watchdog module had a {flood} table, and the watchdog_cron() function deleted old events (older than an hour) from that table. It looks like this functionality (whatever it was), vanished in Drupal 6.

And no, this doesn't apply to D8 -- the doc doesn't mention flood control events, and the documentation looks good there.

Anyway, good call -- yes we need to delete the part of the docs that mentions flood control events from d6 and d7 docs for dblog_cron().

tomgeekery’s picture

Assigned: Unassigned » tomgeekery
Status: Active » Needs review
StatusFileSize
new399 bytes

I edited the dblog.module file and removed the flood control events reference. I am attaching a patch for D7, I assumed I should create a separate comment for the D6 patch. Is that correct?

tomgeekery’s picture

Here is the patch for D6, is it all right to have multiple patches in the same thread for different versions of Drupal?

Status: Needs review » Needs work

The last submitted patch, d6-remove-floor-control-dblog_cron-function-doc-1814760-4.patch, failed testing.

Anonymous’s picture

Once the D7 version fix is applied it will be moved to the 6.x-dev version and the patch retested.

jhodgdon’s picture

tomgeekery: regarding multiple version patches - the short answer is "No, wait". For a longer explanation:
http://drupal.org/node/1319154#multiple-versions

jhodgdon’s picture

Version: 7.x-dev » 6.x-dev
Status: Needs work » Reviewed & tested by the community

Anyway. The patch for d7 looks fine and I committed it to 7.x.

I also reviewed the patch in #4 for Drupal 6.x, and I think it's ready to be committed. Thanks! (I'll ask the test bot to re-test just in case after I change the status/version.)

jhodgdon’s picture

tomgeekery’s picture

Thanks, I apologize for the mix up. Thanks for being so helpful!

jhodgdon’s picture

Assigned: tomgeekery » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed to 6.x -- thanks all!

Automatically closed -- issue fixed for 2 weeks with no activity.