Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Oct 2012 at 22:00 UTC
Updated:
4 Jan 2014 at 02:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedIs this report valid for D8?
Comment #2
jhodgdonWhat are flood control events anyway? Oh I see... In Drupal 5, the watchdog module had a {flood} table, and the watchdog_cron() function deleted old events (older than an hour) from that table. It looks like this functionality (whatever it was), vanished in Drupal 6.
And no, this doesn't apply to D8 -- the doc doesn't mention flood control events, and the documentation looks good there.
Anyway, good call -- yes we need to delete the part of the docs that mentions flood control events from d6 and d7 docs for dblog_cron().
Comment #3
tomgeekery commentedI edited the dblog.module file and removed the flood control events reference. I am attaching a patch for D7, I assumed I should create a separate comment for the D6 patch. Is that correct?
Comment #4
tomgeekery commentedHere is the patch for D6, is it all right to have multiple patches in the same thread for different versions of Drupal?
Comment #6
Anonymous (not verified) commentedOnce the D7 version fix is applied it will be moved to the 6.x-dev version and the patch retested.
Comment #7
jhodgdontomgeekery: regarding multiple version patches - the short answer is "No, wait". For a longer explanation:
http://drupal.org/node/1319154#multiple-versions
Comment #8
jhodgdonAnyway. The patch for d7 looks fine and I committed it to 7.x.
I also reviewed the patch in #4 for Drupal 6.x, and I think it's ready to be committed. Thanks! (I'll ask the test bot to re-test just in case after I change the status/version.)
Comment #9
jhodgdon#4: d6-remove-floor-control-dblog_cron-function-doc-1814760-4.patch queued for re-testing.
Comment #10
tomgeekery commentedThanks, I apologize for the mix up. Thanks for being so helpful!
Comment #11
jhodgdonCommitted to 6.x -- thanks all!