This patch includes the template preprocess function in addition to the twig template.

CommentFileSizeAuthor
#5 d8tts-image-crop-summary-3.patch1.14 KBEVIIILJ
#3 1814814-image-crop-summary-2.patch1.12 KBEVIIILJ
image-crop-summary.patch1.12 KBEVIIILJ

Comments

EVIIILJ’s picture

EVIIILJ commented
Assigned: EVIIILJ » Unassigned
Status: Needs review » Patch (to be ported)
EVIIILJ’s picture

EVIIILJ commented
Status: Patch (to be ported) » Needs review
EVIIILJ’s picture

EVIIILJ commented
StatusFileSize
new 1814814-image-crop-summary-2.patch1.12 KB

Fixed code spacing from tabs to spaces.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Needs work

#3 include theme function
can we remove this ?
all the theme functions has to be removed after all theme(... converted to preprocess
this patch create preprocess with theme call in it
looks like +1 -1

EVIIILJ’s picture

EVIIILJ commented
Status: Needs work » Needs review
StatusFileSize
new d8tts-image-crop-summary-3.patch1.14 KB

The theme() function is ok to use here. See #1810596-11: Convert image_anchor to image-anchor.twig

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented
Status: Needs review » Needs work

I feel it's ok, becouse i believe this theme func needed maybe for additional ability to allow themers to redefine this output. What do you think?

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs work » Fixed

#5 commited / pushed to front-end

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 1750250)