This is a small module that provides the vertical tab contents of a node add/edit form as panels content type. In a panel or a mini panel though the individual contents of the vertical tab are available to be added, but once they are added separately they loose the vertical tabs structure.

This module will provide a single content type "node vertical tab contents" which can be easily added to any pane as contents.

Usage Instructions:
1. Download & Install the module.
2. Create a panel and go to the add content option of the panel name where you want the vertical tabs to be placed.
3. Go to the forms category and select "Node Vertical Tab Elements".

Here is the link to my
Sandbox Project: http://drupal.org/sandbox/aritra.ghosh/1812666
Git Repository: http://git.drupal.org/sandbox/aritra.ghosh/1812666.git
Drupal version: 7.x

Reviews of other projects:
http://drupal.org/node/1427016#comment-6617520
http://drupal.org/node/1765872#comment-6617688
http://drupal.org/node/1800840#comment-6617712

Comments

aritra.ghosh’s picture

aritra.ghosh commented
Issue summary: View changes

Added the Git repo and Sandbox links.

aritra.ghosh’s picture

aritra.ghosh commented
Issue summary: View changes

Modified the links

developmenticon’s picture

developmenticon commented
Status: Needs review » Needs work

Welcome,

Review of the 7.x-1.x branch:

do to other project application review and get review bonus to finish it faster.

developmenticon’s picture

developmenticon commented
Issue summary: View changes

Rectifying the link for the second time!!!!

aritra.ghosh’s picture

aritra.ghosh commented
Status: Needs work » Needs review
Issue tags: +PAreview: review bonus

Thanks developmenticon,

Fixed all the issues according to your guidelines and also additional errors appearing in error report of automatic code sniffer. Changing the status to needs review and adding review bonus tag.

varunmishra2006’s picture

varunmishra2006 commented

Manual Review

The code seems to be fine. I installed the module and functionality seems to be working.
However , the project page don't contain enough description. I request you to edit the project page to add more details. Please read http://drupal.org/node/997024

Automated Review, ventral.org still show one minor warning. Please remove it.

Apart from this everything is fine.

varunmishra2006’s picture

varunmishra2006 commented
Issue summary: View changes

Added the reviews to other projects section

aritra.ghosh’s picture

aritra.ghosh commented

Thanks varunmishra2006,

I have updated the project page with more details installation and usage guide.

Regarding the warning that is coming up in drupal code sniffer: http://ventral.org/pareview/httpgitdrupalorgsandboxaritraghosh1812666git I am really not sure what it is and how i can fix it. If any of you guys can point me in right direction that would be great.

dSero’s picture

dSero commented

Hi,

I look like a very nice project that probably will help many drupal users.

Please notice several issues that may consider to take care of:
1. Regarding the automatic review error that you got. Just change line #9 from " * Implementation of hook_ctools_plugin_directory()." to " * Implements hook_ctools_plugin_directory()."
2. node_vertical_tab_elements.inc: line #42-43, can be merged to a single line

Best Regards,
Moshe

dSero’s picture

dSero commented
Status: Needs review » Needs work

Changed to needs work

aritra.ghosh’s picture

aritra.ghosh commented
Status: Needs work » Needs review

Thanks dSero,

Fixed the issues raised by you. Changing the status to needs review.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus +PAreview: single application approval

manual review:

  1. node_vertical_tab_elements.info: dependency to panels and possibly other modules are missing?
  2. This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

aritra.ghosh’s picture

aritra.ghosh commented

Thanks Klausi,
I did not have any idea regarding this 120 line 5 function restriction. But thanks to all of you for your time and patience reviewing this small project. In this case, I would like to know if I have another project ready to be reviewed by the community, shall I delete this project page and submit it to be reviewed by the community? or let this page remain to re reviewed l8tr once I have full git access?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

no objections for more than a week, so ...

Thanks for your contribution, aritra.ghosh!

I promoted this project manually for you: http://drupal.org/project/node_vertical_tab_elements

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Open a new application whenever you have a new project ready that does not exist yet that you want to promote.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Added description