My themers ask me for first/last classes on things on a constant basis. primary/secondary links already have them, but other lists don't. Attached patch adds first/last classes to all theme_item_list lists as well as to all menu block lists. It's just extra hooks for themers to play with.

CommentFileSizeAuthor
#6 notices_9.patch642 byteswebernet
#2 firstlast_0.patch3.4 KBCrell
firstlast.patch4.07 KBCrell

Comments

yched’s picture

yched commented

Ooh yes, +1.
The parts that affect menu_local_tasks() seem unneeded ?

Crell’s picture

Crell commented
StatusFileSize
new firstlast_0.patch3.4 KB

Indeed, that's because they are. :-) I had tried to add first/last there as well, but gave up because that function scares me.

yched’s picture

yched commented
Status: Needs review » Reviewed & tested by the community

ready then...

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Good idea, good code, committed.

webernet’s picture

webernet commented
Status: Fixed » Needs work

This patch introduced the following notices on admin/build/modules

* notice: Undefined variable: items in /includes/menu.inc on line 596.
* notice: Undefined variable: items in /includes/menu.inc on line 597.
* warning: Invalid argument supplied for foreach() in /includes/menu.inc on line 597.

webernet’s picture

webernet commented
Status: Needs work » Needs review
StatusFileSize
new notices_9.patch642 bytes
dvessel’s picture

dvessel commented
Status: Needs review » Reviewed & tested by the community
Stefan Nagtegaal’s picture

Stefan Nagtegaal commented

Simple one-liner, RTBC!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

That was quick, thanks, committed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)