Posted by moshe weitzman on October 8, 2007 at 12:21am
5 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | user system |
| Category: | feature request |
| Priority: | normal |
| Assigned: | moshe weitzman |
| Status: | closed (fixed) |
Issue Summary
Just some more cleanup. There is no reason all user_save() calls have to endure some distributed auth code. I checked OpenID and it is unaffected by this patch.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| mw_88.patch | 1.76 KB | Ignored: Check issue status. | None | None |
Comments
#1
in order to test this, just do a registration and a login via distributed auth (i.e. enable drupal.module and login with @drupal.org) and make sure all is well.
#2
subscribing
#3
So where does this auth information saved instead?
#4
drupa.module calls user_set_authmaps() after this patch. openid calls into the authmap table directly.
#5
Again, this patch does not touch drupal.module, so drupal.module might register with user_external_login_register() then?!
#6
@Gabor - you are right. The relevant change is in user_external_login_register().
My statement in the other issue is incorrect. drupal.module is unchanged by this patch and can be booted at any time.
#7
This still applies cleanly. drupal.module has gone but I assume this is still a valid issue?
#8
Yes, in principle this looks good, but another set of eyes would never hurt.
#9
sigh.
#10
refreshed. i did need to change two lines in openid module so that it creates its own authmap entry instead of relying on user_save().
#11
now with patch
#12
I think this patch might need a re-roll because of the schema API patch that got committed?
#13
I rerolled after that one landed. Should be good to go.
#14
Looks good to me. Makes for cleaner code. Committed this patch to CVS HEAD.
#15
Automatically closed -- issue fixed for two weeks with no activity.