On the dedicated /legal page it makes no sense to have a scrollbox, since there's no other content on the page. It only makes it harder for users to read your ToS. It also makes little sense to display the HTML version in full on the registration page since most ToS are very long and the user will have to scroll through a lot of it just to hit the checkbox and move on.

I think it would be reasonable to have some different settings. I envision that the user enters an HTML formatted version that is displayed in full-HTML beauty on the /legal page. I think then the user can select either scrollbox option or a link option that someone else suggested for the registration page. You could leave the HTML option for the registration page if you wanted, but I'm sure almost no one uses that option (I could be wrong though).

CommentFileSizeAuthor
#2 legal.patch53.04 KBSusurrus

Comments

Susurrus’s picture

Susurrus commented

if anyone else is interested in the improvements I suggest, I would be happy to provide a patch for this functionality.

Susurrus’s picture

Susurrus commented
Title: Allow both HTML and non-HTML versions » Apply better formatting to stand-alone T&C page
StatusFileSize
new legal.patch53.04 KB

I've attached a patch which formats the stand-alone T&C page (set by this modules to /legal) to display HTML if either the CSS Scroll Box or the HTML T&C options are selected. Plain text for the Scroll Box option is passed through nl2br() so that all newlines are shown in HTML and displayed instead. This allows the /legal page to actually allow reading of the T&C since a tiny scroll box is not the way to read a large passage of text, especially on a page where only it is being displayed.

The README.txt file has also been updated to describe this new functionality as well as hook_help().

Sorry about the patch file and its size, though it should still work fine, WinMerge doesn't seem to be cooperating right now, but I'm not sure why...

Susurrus’s picture

Susurrus commented
Status: Active » Needs review

Forgot to tell people to check out the patch...

robert castelo’s picture

robert castelo commented
Status: Needs review » Reviewed & tested by the community

Thanks. Will commit shortly.

robert castelo’s picture

robert castelo commented
Status: Reviewed & tested by the community » Closed (fixed)

Patch applied - many thanks Susurrus.