Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Tidied up the whitespace issues identified by coder.module. Mostly just tabs. One remaining warning about the use of globals.
No actual code changes, so attached patch RTBC immediately I think.
I just wanted to clean-slate this project before extending it with it with CSV and RDF-style import/export options.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | taxonomy_xml_coding_standards_02.patch | 11.61 KB | dman |
| taxonomy_xml_coding_standards.patch | 6.82 KB | dman |
Comments
Comment #1
dman commentedHere's a HEAD re-do.
It's largely heaps of trivial whitespace fixes for the code style review, although to follow the super-strict recommendations it also renamed the globals into a namespace.
I don't think this should break anything, so it's RTBC again, but I'll leave it in the queue for a day or two to give a chance to look it over.
There's no significant changes or fixes, just strict syntax stuff.
Comment #2
dman commentedOK. I've folded that in and committed
No changes should be visible in the actual module however.
Thanks to Nicolas for the add.
Comment #3
dman commentedprevious patch went in on the trunk (which had to be done anyway) - I'm now also commiting to the DRUPAL-5 branch. ... which would have been the reason the previous patch didn't go on cleanly also. (but the network is bugging me now)
edit: Drupal.org went away when I was in the middle of a patch ... nasty CVS lock happened. something may be a little broken. investigating.
Comment #4
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.