I noticed when I use this theme and even on your own demo site I get a js error.

Line: 26
Error: Object doesn't support property or method 'nivoSlider'

The error does not exist on the home page, but when you go to other pages the error is there.

CommentFileSizeAuthor
#6 company--nivoslider-js-error-1816114-6.patch971 byteshargobind
#5 company--nivoslider-js-error-1816114-5.patch968 byteshargobind
#3 company-1816114-nivoslider_js_error-2.patch0 bytesvidit.anjaria

Comments

mabbus21’s picture

mabbus21 commented
Issue summary: View changes

This happens because the slider div isn't there.

I would wrap the slider function in an if statement and check if slider exists:

if ( $('#slider').lengh ) {
     $('#slider').nivoSlider();
}

This fixed it for me.

vidit.anjaria’s picture

vidit.anjaria commented
Assigned: Unassigned » vidit.anjaria
vidit.anjaria’s picture

vidit.anjaria commented
Assigned: vidit.anjaria » Unassigned
Priority: Normal » Minor
Status: Active » Needs review
StatusFileSize
new company-1816114-nivoslider_js_error-2.patch0 bytes

providing a patch for this issue, so it would be easy to port into working branch.

krina.addweb’s picture

krina.addweb commented
Status: Needs review » Needs work

@vidit.anjaria Your patch din't works for me.

hargobind’s picture

hargobind
he/him
Location Austin, Texas
commented
Version: 7.x-1.4 » 7.x-1.5
Component: User interface » Code
Status: Needs work » Needs review
StatusFileSize
new company--nivoslider-js-error-1816114-5.patch968 bytes

Attached is a patch that checks to see if the nivoSlider function exists.

hargobind’s picture

hargobind
he/him
Location Austin, Texas
commented
StatusFileSize
new company--nivoslider-js-error-1816114-6.patch971 bytes

Fixed a typo in #5.