I've just seen the following in my log after sending a test feedback message:

Joachim <$from> sent a feedback e-mail

It looks like the variable isn't getting parsed properly.

CommentFileSizeAuthor
#2 feedback_log.patch543 bytesyarikmsu

Comments

joachim’s picture

joachim commented
Status: Active » Needs review

The fix is at line 452: the string with the $from variable needs double instead of single quotes, like this:

  if ($page->logging) {
    watchdog('mail', t('@name-from sent a feedback e-mail', array ('@name-from' => $edit['emailname'] . " <$from>")));
  }
yarikmsu’s picture

yarikmsu commented
Status: Needs review » Needs work
StatusFileSize
new feedback_log.patch543 bytes
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Development on Feedback module v1.x has ended. Beginning from 2.x, the Feedback module has been replaced with a completely different module with a different purpose. Please note that Feedback 2.x is not compatible with 1.x. See #279636: Turn Feedback into user feedback module for further information.

There will be a final 5.x-1.1 release with all existing and tested patches in the issue queue applied. If you need the functionality of the Feedback 1.x module, the Contact module in Drupal core as well as the contributed Webform module are recommended replacements. However, there is no migration path to those modules.

joachim’s picture

joachim commented

I've been using Feedback 1.x on sites because I think it has a much better feature set than the Core contact module.
And it seems to me that your new version, User Feedback doesn't quite do the same thing...

EDIT: Hmm, on second thoughts, Webform does look pretty cool :)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

So do we still need to commit this patch?

joachim’s picture

joachim commented

I would if I were you. It's there and it fixes the problem and a lot of sites build on Drupal 5 still.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Committed to 5.x-1.x.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.