Webform will show wrong confirmation message when tnid = 0
This because of the query in webform_localization_preprocess_webform_confirmation can give multiple results in that case.

Patch will follow

CommentFileSizeAuthor
#5 webform_localization-wrong_message-1816592-12.patch595 bytesleksat
#1 1816592_1_wrongconfirmationmsg.patch.txt2.23 KBrv0

Comments

rv0’s picture

rv0 commented
Status: Needs work » Needs review
StatusFileSize
new 1816592_1_wrongconfirmationmsg.patch.txt2.23 KB
minoroffense’s picture

minoroffense commented

I can confirm this issue. Happens when using Entity Translation and tnid is set to 0 and the sync is set to 0.

minoroffense’s picture

minoroffense commented
Status: Needs review » Needs work

Patch doesn't apply anymore though.

rv0’s picture

rv0 commented

looking at the path, its just a matter of adding ad IF statement around the code
a re-roll cant be hard ;)

if (isset($vars['node']->tnid) && $vars['node']->tnid > 0) {

sure you took the 1.x branch?

leksat’s picture

leksat commented
Status: Needs work » Needs review
StatusFileSize
new webform_localization-wrong_message-1816592-12.patch595 bytes

A bit different patch for 7.x-1.x (with the same logic).

GDrupal’s picture

GDrupal commented
Status: Needs review » Fixed

Committed thank you all guys!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.