Download & Extend
Mollom » Issues

Allow to retain and moderate unsure posts instead of showing CAPTCHA

Posted by sun on October 19, 2012 at 9:30am
Project:Mollom
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:sun
Status:closed (fixed)

Issue Summary

Goal

  • When text analysis is unsure, retain posts as "unpublished" for manual moderation instead of showing a CAPTCHA.

Details

  • The default behavior for an "unsure" response is to show a CAPTCHA.
  • The Mollom module already supports to retain posts for manual moderation when text analysis identifies spam.
  • What is missing and desired is to retain posts for manual moderation when text analysis is unsure, instead of showing a CAPTCHA.

Related issues

Login or register to post comments

Comments

#1

Posted by sun on October 19, 2012 at 9:55am
Status:active» needs review

If all goes well, this should actually work already.

AttachmentSizeStatusTest resultOperations
mollom.unsure-moderate.1.patch4.59 KBIdlePASSED: [[SimpleTest]]: [MySQL] 4,371 pass(es).View details

#2

Posted by sun on October 19, 2012 at 10:22am
Status:needs review» reviewed & tested by the community

Added tests.

AttachmentSizeStatusTest resultOperations
mollom.unsure-moderate.2.patch8.85 KBIdlePASSED: [[SimpleTest]]: [MySQL] 4,472 pass(es).View details

#3

Posted by sun on October 19, 2012 at 10:26am

Screenie of new setting:

mollom-unsure.2.png

AttachmentSizeStatusTest resultOperations
mollom-unsure.2.png17.36 KBIgnored: Check issue status.NoneNone

#4

Posted by sun on October 19, 2012 at 10:40am
Title:Allow to retain + moderate unsure posts instead of showing CAPTCHA» Allow to retain and moderate unsure posts instead of showing CAPTCHA
Status:reviewed & tested by the community» fixed

Committed and pushed to 7.x-2.x.

#5

Posted by robeson on October 31, 2012 at 3:59pm

Does this setting only show up for comments? I want to be able to retain/moderate spam webform submissions but am not seeing the option (7.x-2.3).

#6

Posted by System Message on November 14, 2012 at 4:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#7

Posted by sun on February 6, 2013 at 3:05pm
Version:7.x-2.x-dev» 6.x-2.x-dev
Status:closed (fixed)» needs review

@lrobeson: In general, the "retain as unpublished" facility is only available for posts/entities that support a notion of a "unpublished" status. Webform submissions do not have such a status.

Attached patch backports this code to 6.x-2.x.

AttachmentSizeStatusTest resultOperations
1817446-moderate-unsure.patch9.22 KBIdleFAILED: [[SimpleTest]]: [MySQL] 132 pass(es), 55 fail(s), and 2 exception(s).View details

#8

Posted by sun on February 6, 2013 at 3:07pm

Missing $ret in db_add_field() of the module update.

AttachmentSizeStatusTest resultOperations
1817446-moderate-unsure.patch9.22 KBIdleFAILED: [[SimpleTest]]: [MySQL] 3,935 pass(es), 16 fail(s), and 15 exception(s).View details

#9

Posted by System Message on February 6, 2013 at 3:10pm
Status:needs review» needs work

The last submitted patch, 1817446-moderate-unsure.patch, failed testing.

#10

Posted by sun on February 6, 2013 at 3:49pm
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
1817446-moderate-unsure.patch9.22 KBIdleFAILED: [[SimpleTest]]: [MySQL] 3,934 pass(es), 15 fail(s), and 15 exception(s).View details

#11

Posted by System Message on February 6, 2013 at 3:51pm
Status:needs review» needs work

The last submitted patch, 1817446-moderate-unsure.patch, failed testing.

#12

Posted by sun on February 7, 2013 at 1:55pm
Status:needs work» needs review

Sorry, the form constructor used a facility that only exists in D7+. This one should pass.

AttachmentSizeStatusTest resultOperations
1817446-moderate-unsure.patch9.25 KBIdleFAILED: [[SimpleTest]]: [MySQL] 3,951 pass(es), 1 fail(s), and 3 exception(s).View details

#13

Posted by System Message on February 7, 2013 at 2:38pm
Status:needs review» needs work

The last submitted patch, 1817446-moderate-unsure.patch, failed testing.

#14

Posted by sun on February 7, 2013 at 3:04pm
Status:needs work» needs review

Heh. It would definitely help if I'd locally run the tests on D6 instead of D7 ;)

AttachmentSizeStatusTest resultOperations
1817446-moderate-unsure.patch9.26 KBIdlePASSED: [[SimpleTest]]: [MySQL] 3,952 pass(es).View details

#15

Posted by sun on February 7, 2013 at 4:09pm
Status:needs review» fixed

Committed and pushed to 6.x-2.x.

#16

Posted by System Message on February 21, 2013 at 4:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.