change title in omniture_menu to reflect "site catalyst"
StephenGWills - October 8, 2007 - 19:57
| Project: | Omniture Integration |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Omniture is the company but they have other products I think we might want to support in Drupal as well as Site Catalyst, which is the product this module integrates. I suggest we change the menu items for title and description to reflect that.
in items array:
'title' => t('Site Catalyst'),
'description' => t('Configure the settings used to generate your Site Catalyst reporting database.');
what do you think?
#1
other candidates for this notation might be on line 17 in omniture_help and line 35, 'access', in omniture_menu
#2
Well that seems reasonable to me.
How about a patch? http://drupal.org/patch/create
#3
This patch modifies text strings to reflect the SiteCatalyst product name.
#4
here's a slightly reworked version
1) you changed the name in the "access" attribute of the menu item but didn't change it in the omniture_perm - effectively that makes it impossible for anyone to get the right permission to edit the stats except for uid1.
2) I also wanted to rename it throughout the documentation, in the .info file, etc. so that the interface would be more consistent.
What do you think? Can you test this out and confirm it makes sense?
#5
I am uploading another patch that corrects some single/double quote conflicts and a typo so things will execute better. Caveat is that this patch, while fixing some syntax is still untested. It is submitted to facilitate testing only. I think I'm in the right branch now!!!
#6
Can you clarify the differences between my patch in #4 and your patch in #5? Was there something specific you were trying to address or are they basically the same goal?
#7
#4 and #5 are the same goal.
In one place, site "catalyst" was spelled "caralyst" and in another "omniture's" was breaking a text formatter i.e. t('omniture's'); If you want I can go back and find what I fixed. These items needed to be repaired to do Q/A on the logic. It was only 3-4 items like that which I wanted to save other testers from having to fix in the patch in order to try out the revision.
#8
Ok, so you made some fixes from my patch, then - yours is further progress from mine.
In general when uploading a new patch it's good to say something like "I started from XYZ and then added/removed LMNOP"
#9
@Blessed_Steve - I just noticed that your cvs account got approved so I added you as a maintainer of this module. You should be able to commit anything to the contributions/modules/omniture directory in CVS. I'm currently working on the DRUPAL-5 branch so you should use that branch for your work as well.
Let me know if you have any questions or problems as you work on this and I'll try to provide my insights via the issue queue.
#10
http://drupal.org/cvs?commit=144796
I guess this isn't so necessary for 5.x so I'm marking it fixed instead of "to be ported".
#11
Automatically closed -- issue fixed for two weeks with no activity.