Download & Extend

Undefined index: triggers in flag_flag->get_valid_actions()

Project:Pathauto
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (duplicate)

Issue Summary

Problem/Motivation

The mimemail module causes errors in the flag module because it fails to specify triggers in mimemail_rules_action_info. According to the documentation for hook_action_info, the 'triggers' key is required. See this comment from the author of the flag module saying that he does not consider this to be a bug in that module.

Proposed resolution

Add 'triggers' => array('any') to mimemail_rules_action_info.

Remaining tasks

Will attach my patch but needs testing.

Comments

#1

Status:active» needs review

My proposed patch is attached.

AttachmentSizeStatusTest resultOperations
mimemail-action-triggers-1817898-1.patch698 bytesIgnored: Check issue status.NoneNone

#2

Project:Mime Mail» Pathauto
Version:7.x-1.x-dev» 7.x-1.x-dev
Status:needs review» closed (duplicate)

The hook_action_info() implementation in Mime Mail is right, see in the repository. I think this was triggered and fixed by Pathauto in #1356786: Notice: Undefined index: triggers in flag_node->get_valid_actions() (line 1334 of /hsphere/local/home/...../sites/all/modules/fl.

nobody click here