Just checking out d3 I did not get Graph API to work.

So I spent 2 hours trying to get this going.

Do you mind to give me git access or better full access :)

Comments

clemens.tolboom’s picture

Status: Active » Needs review
StatusFileSize
new11.13 KB

After applying the patch you need to drush rr as the class files are now autoloaded.

Next enable Graph API and visit admin/config/system/graphapi/demo to see all 3 d3 engines appear in name and 1 in svg rendering (all white coloring?!?)

It's a step forward.

asherry’s picture

Status: Needs review » Postponed (maintainer needs more info)

I'm reviewing this now. Great changes, I appreciate adding in the check for the library, that I was meaning to do.

First question - why are you adding graphapi support for bar graphs and line graphs? I was under the impression the graph api was only supporting force directed graphs. I'm not sure I want the d3 module to have to depend on graphapi to render anything else other than force directed graphs.

clemens.tolboom’s picture

Status: Postponed (maintainer needs more info) » Needs review

A lot a D3 renderers are possible with Graph API

All examples on https://github.com/mbostock/d3/wiki/Gallery having
- Hierarchical
- Tree
- Graph
in their name are capable for Graph API including. And also

- Bubble Chart
- Chord Diagram
- Dendrogram
- Force-Directed Graph
- Circle Packing
- Sunburst
- Node-Link Tree
- Co-occurrence Matrix
- etc.

The data structures of D3 and thejit are 'node' related having attributes. Some have hierarchical structures.

Graph API can deliver Field Mappers with only 'left' nodes, or 'left' + link to + 'right nodes with attributes. As I said in #1505388: d3.js Data-Driven Documents integration comment #13 I wondered to make Graph API relaxing on the right node (the to-ID is now required to be mapped).

If we take that hurdle Graph API can be your data provider for all D3 renderings.

asherry’s picture

I don't want to use graphapi for every type of visualization associated with d3. That will be limiting for some types of visualizations that are really complex and have multiple data structures.

Can you re submit the patch without the .module code that depends on additional modules? Also your patch is looking for a file that I removed in another issue. I apologize for that.

clemens.tolboom’s picture

Status: Needs review » Closed (won't fix)

I'm sorry to hear this.

Then I have to build d3 integration myself.

asherry’s picture

Status: Closed (won't fix) » Needs work

please don't mislabel this. I asked you to resubmit the patch because a file was changed and it's getting an error.

I also asked you to make one change to take out the submodule code, as I don't agree with you that that is the way to go with this project.

clemens.tolboom’s picture

You can copy paste code from the patch yourself. That is probably quicker. I've a 120% workload now :-) / :-(

asherry’s picture

ok I essentially replicated most of what you had anyway. It's heavily dependent now on libraries, and loads all visualizations and javascript via libraries. I think this gives great flexibility in terms of adding new d3 visualizations, and also in terms of each visualization having css and extra js files.

There of course always is the possibility for developers to create addon modules with advanced functionality, but in order to produce graphs it won't be necessary to actually create additional modules.

Have a look, let me know what you think

asherry’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

asherry’s picture

Project: » d3.js
Version: » 7.x-1.x-dev
Issue summary: View changes