Module info

The aim of Simple Twitter is to make it really easy to display Twitter data (specifically user tweets) on a Drupal site. The module is written with a view to end-users needing zero code writing abilities.

Twitter Pull is a module that performs a similar task to Simple Twitter (in this it allows the user to display tweets on the front-end). The issue with the Twitter Pull method is that it requires the end-user to drop PHP code into the page and configure the tpl.php file if they want to change the display. With Simple Twitter you access the config page (at admin/config/simple_twitter/config), select the items you want to display in each tweet, the number of tweets you want to display and the username of the Twitter account you want to load and you're done. Simple Twitter then creates a block which can be dropped anywhere on the site.

Git

git clone --recursive --branch master http://git.drupal.org:sandbox/craigweb/1818578.git simple_twitter
cd simple_twitter

Project Page

http://drupal.org/sandbox/craigweb/1818578

Drupal version

The module is written for Drupal 7

CommentFileSizeAuthor
Simple Twitter - Config Page25.2 KBcraigperks
Simple Twitter - Front End Display60.78 KBcraigperks

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Postponed (maintainer needs more info)

This sounds like a feature that could go directly into twitter_pull or similar modules. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the twitter_pull issue queue or for another similar module and get in contact with the maintainer(s). Offer your wanted feature as patch or ask for co-maintainership.

If that fails for whatever reason please get back to us and set this back to "needs review".

craigperks’s picture

craigperks commented

As a follow-up, I've posted a thread in the Twitter Pull module issue queue in the hope that I can do as you suggested klausi http://drupal.org/node/1833710 :-)

craigperks’s picture

craigperks commented
Status: Postponed (maintainer needs more info) » Needs review

I posted in the Simple Twitter issue queue as instructed, but haven't received a response in almost 5 days now: http://drupal.org/node/1833710

I've done a significant re-working of my module this weekend and I'm keen to share the code with the rest of the community as I'm sure what I've done would be useful to other people - how should I proceed?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Postponed (maintainer needs more info)

Did you contact the maintainers directly? Offer your wanted feature as patch or ask for co-maintainership.

If that fails for whatever reason please get back to us and set this back to "needs review".

craigperks’s picture

craigperks commented
Status: Postponed (maintainer needs more info) » Needs review

Hi Klausi,

Yeah - I've contacted everyone I could related to that module and I've not had a response from anyone. I was happy to contact them as you suggested and look at getting the features in my module implemented into Twitter Pull, but I do feel that my module is different enough (aimed at non-coders) to warrant being a standalone module, which I do also intend to develop further.

Thanks,
Craig

gazoakley’s picture

gazoakley commented
Status: Needs review » Needs work

Hi craigperks,

The PAReview tool found various issues for your module:

http://ventral.org/pareview/httpgitdrupalorgsandboxcraigweb1818578git

  • It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
     
  • ./simple_twitter.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
     
  • Remove all old CVS $Id tags, they are not needed anymore.: simple_twitter.info:1:;$Id:$
     
  • Additionally there are Drupal Code Sniffer issues - please visit the link above to review the full list
     
craigperks’s picture

craigperks commented

Hi gazoakley,

Thanks for the reply. I did run the module through coder and managed to get it issue free, so it's good to see how it fared on another tool. I've now removed all issues that the PAReview tool you linked to listed: http://ventral.org/pareview/httpgitdrupalorgsandboxcraigweb1818578git

Thanks,
Craig

craigperks’s picture

craigperks commented

Hi all,

Does anyone know if there is a way to check if this module is in some form of backlog for review, or whether it's dropped off the radar completely?

I'm getting emails from people with patches and recommendations for further additions, so I do feel that there is a demand for this module to be available to all users and not just people who can pull the dev code down using Git.

Thanks,
Craig

craigperks’s picture

craigperks commented
Status: Needs work » Needs review
PDNagilum’s picture

PDNagilum commented
Status: Needs review » Needs work

Pretty simple to setup and use mode. I like it :)

Manual review:

  • Right after I activated the module I got two Invalid argument warnings from simple_twitter.module on lines 279 and 287. You cycle through empty arrays. Load the arrays into variables and do a count() check before cycling them to avoid such warnings.
  • You have a call to simple_twitter_retrieve_tweets() and drupal_add_css outside of any function. The CSS call should be added to the .info file if it's going to be added on each request.
  • The retrieve_tweets() function shouldn't really be called on every request as this has the potential to really slow down the entire site. Consider adding it as a cronjob, or implement caching of the tweets. Only adding a minute of cache will help speed things up.
  • When saving the admin config, some debugging info popped up ;)
  • Your block is named "Block: Simple Twitter", the "Block: " part is uneeded.
  • I would really love to have some layout control over how the tweets are displayed. Put the tweet test next to the image and so on.. Little things that would make it pretty awesome since it's targeted at non-coders.
PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

joachim’s picture

joachim commented

> The issue with the Twitter Pull method is that it requires the end-user to drop PHP code into the page and configure the tpl.php file if they want to change the display. With Simple Twitter you access the config page (at admin/config/simple_twitter/config), select the items you want to display in each tweet, the number of tweets you want to display and the username of the Twitter account you want to load and you're done. Simple Twitter then creates a block which can be dropped anywhere on the site.

Twitter Pull now has support for Boxes module: create a box, set the twitter username (or search tag), and that gives you a block showing that twitter feed.