Checking filter default format gives false positives and puts annoying and insufficient info about the problem

Comments

heine’s picture

Can you please elaborate?

westwesterson’s picture

I have run into this too.

There are modules which enable users to pick certain default filters for certain users. If you have Filtered HTML the default for some users (for security issues), but then have other users use a format which isn't filtered lets say the site admin, which has a less secure filter like the rich text editor suggested in the documentation, you still get an error saying that the default filter is enabled.

Here are a couple of solutions:
1) This could be changed from a critical error, to a more friendly feedback option.
2) Put this in the documentation, and take out the error message.

I'm more inclined to just changing from an error to a status message AND putting it in the documentation. This may have weird effects for people who expect it to work out of the box without a filter change and who don't heed the warning, but there are some use cases where people intentionally leave the sitewide default filter as Filtered HTML.

heine’s picture

Priority: Normal » Critical

Thanks.

  // check if input format is not filtered HTML
  if (variable_get('filter_default_format', 1) == 1) {
    drupal_set_message(t('The input format "Filtered HTML" is enabled. It is recommended to turn off HTML filters when using the Whizzywig editor. ').l(t('Change input format settings'), 'admin/settings/filters'),'error');
  }

This piece should go, HTML filters should never be disabled.

sdecabooter’s picture

You're right... my bad.
I removed the errormessage altogether, and updated the README.txt to make the instructions more clear on this matter.
I also added a descriptive message on top of the Whizzywig settings page, which is less 'harsh' then an error message.

sdecabooter’s picture

Status: Active » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)