New permission 'show adsense placeholders' [#1819510]

On a live site, I have found it useful to disable google ads and show the placeholder for specific users who are
not site admin. These are users which run and manage the site, are on it a lot of the time and do not want to be exposed to accidentally clicking on the live ad. But they need to see where they are placed, and check that all is correct.

I created the new permission 'show placeholder' which can be assigned to any role as usual. It is checked in adsense_display() in addition to when the entire site ads are disabled and/or the user is the site admin. Patch to follow.

Comment	File	Size	Author
#1	_1819510_1.adsense.placeholder_perm.d6.patch	1.25 KB	jonathan1055
#3	1819510-3-placeholder_permission-d6.patch	1.66 KB	fenstrat
#3	1819510-3-placeholder_permission-d7.patch	1.76 KB	fenstrat

Comments

Comment #1

jonathan1055 commented 14 November 2012 at 08:38

Title:	New permission 'show adsense placeholders'	» New permission 'show placeholder'
Version:	7.x-1.x-dev	» 6.x-1.4
Status:	Reviewed & tested by the community	» Active

Status	File	Size
new	_1819510_1.adsense.placeholder_perm.d6.patch	1.25 KB

Here is the patch against 6.x-1.4 as that is what I am using in production.
It applies ok to the latest dev but with offsets.

Three functions are changed: hook_perm(), adsense_display() and _adsense_check_if_enabled()

Comment #2

jonathan1055 commented 22 October 2012 at 12:43

Status:

Active

» Needs review

Forgot to change the status.

Comment #3

fenstrat

he/him

English

Australia

commented 13 November 2012 at 20:14

Title:	New permission 'show placeholder'	» New permission 'show adsense placeholders'
Version:	6.x-1.4	» 7.x-1.x-dev
Status:	Needs review	» Reviewed & tested by the community

Status	File	Size
new	1819510-3-placeholder_permission-d7.patch	1.76 KB
new	1819510-3-placeholder_permission-d6.patch	1.66 KB

Works well. I've made a couple minor changes:

"show placeholder" is to generic a permissions, changed to "show adsense placeholders".
Placeholders also output "Ads disabled for site admin", so I've also changed that to use $user->name.
Also included a D7 version.
RTBC as these changes are minor and the new permission works as expected.