I get the following error when strict error reporting is enabled:

Strict warning: Declaration of pay_method_direct::form_submit() should be compatible with that of pay::form_submit() in pay_load_handler() (line 238 of pay/pay.module).

Attached patch fixes this.

Comments

clevername’s picture

Thank you.

quicksketch’s picture

Status: Needs review » Reviewed & tested by the community

+1

Seph’s picture

Tried applying the patch but it failed. I got the following error:

Hunk #1 FAILED at 150.
patch unexpectedly ends in middle of line

d0t15t’s picture

Issue summary: View changes

Patch succeeded & corrected the problem

kebz’s picture

Priority: Normal » Critical
Status: Reviewed & tested by the community » Needs work

Was the patch ever committed into the module?? That was 2 years ago ... and 2 years later, I'm getting multiple warnings at the same time??

Strict warning: Declaration of pay_method_direct::form_submit() should be compatible with pay::form_submit($form, &$form_state) in pay_load_handler() (line 238 of .../sites/all/modules/pay/pay.module).

Backtrace:
pay_load_handler() pay.module:238
pay_load_handler('pay_method', 'pay_method_direct') pay.module:229
pay_load_handler('pay_method', 'pay_method_direct_paypal') pay.module:299
pay_load_object('pay_method', Array) pay.module:412
pay_form_callback('validate', Array, Array) pay.module:395
pay_validate(Array, Array) form.inc:1513
form_execute_handlers('validate', Array, Array) form.inc:1453
_form_validate(Array, Array, 'pay_admin_method_form') form.inc:1183
drupal_validate_form('pay_admin_method_form', Array, Array) form.inc:889
drupal_process_form('pay_admin_method_form', Array, Array) form.inc:385
drupal_build_form('pay_admin_method_form', Array) form.inc:130
drupal_get_form('pay_admin_method_form')
call_user_func_array('drupal_get_form', Array) menu.inc:517
menu_execute_active_handler() index.php:21

Strict warning: Declaration of pay_method_direct::form_submit() should be compatible with pay::form_submit($form, &$form_state) in pay_load_handler() (line 238 of /homepages/30/d513154960/htdocs/OVLVX_com/BLove/sites/all/modules/pay/pay.module).

Backtrace:
pay_load_handler() pay.module:238
pay_load_handler('pay_method', 'pay_method_direct') pay.module:229
pay_load_handler('pay_method', 'pay_method_direct_paypal') pay.module:299
pay_load_object('pay_method', 2) pay.module:315
pay_method_load(2) pay.admin.inc:187
pay_admin_method_overview()
call_user_func_array('pay_admin_method_overview', Array) menu.inc:517
menu_execute_active_handler() index.php:21

Strict warning: Declaration of pay_method_direct::form_submit() should be compatible with pay::form_submit($form, &$form_state) in pay_load_handler() (line 238 of .../sites/all/modules/pay/pay.module).

Backtrace:
pay_load_handler() pay.module:238
pay_load_handler('pay_method', 'pay_method_direct') pay.module:229
pay_load_handler('pay_method', 'pay_method_direct_paypal') pay.module:299
pay_load_object('pay_method', 2) pay.module:315
pay_method_load(2) pay.admin.inc:187
pay_admin_method_overview()
call_user_func_array('pay_admin_method_overview', Array) menu.inc:517
menu_execute_active_handler() index.php:21

Strict warning: Declaration of pay_method_direct::form_submit() should be compatible with pay::form_submit($form, &$form_state) in pay_load_handler() (line 238 of .../sites/all/modules/pay/pay.module).

Backtrace:
pay_load_handler() pay.module:238
pay_load_handler('pay_method', 'pay_method_direct') pay.module:299
pay_load_object('pay_method', 'pay_method_direct') pay.module:315
pay_method_load('pay_method_direct') pay.module:524
pay_currency_list() pay.admin.inc:24
pay_admin_settings(Array, Array)
call_user_func_array('pay_admin_settings', Array) form.inc:841
drupal_retrieve_form('pay_admin_settings', Array) form.inc:350
drupal_build_form('pay_admin_settings', Array) form.inc:130
drupal_get_form('pay_admin_settings') pay.admin.inc:14
pay_admin_overview()
call_user_func_array('pay_admin_overview', Array) menu.inc:517
menu_execute_active_handler() index.php:21

arruk’s picture

The code on my site reflects that this patch is either installed or has been added to the code base, however I am still getting the same error.

sealionking’s picture

i got the error too
payment 7.x

sealionking’s picture

StatusFileSize
new8.02 KB

with the error, the content type editing page cannot do the payment settings job
as the img show
can not setting payment

Tachukadi’s picture

Hi, Can someone put some light on error we get plz, i have same error on drupal 7 installed, look at this screenshot http://prntscr.com/jl92ur

sorry, but i am just new to drupal yet and learning things, but when i tried to make donation form, i am just getting such errors on form, wish if someone can help it out.