I'm trying to combine normal File fields and Flickr fields into one Media field, but defining a file_class per row doesn't seem supported.
In the /plugins/destinations/fields.inc file, in the MigrateFileFieldBaseHandler class a general fileclass argument is used, instead of the file_class from the instance_arguments. This caused this part of the code to break when fileclass is an array.

One temp fix seems to be to add 

$file_class = $instance_arguments['file_class'];

above the following

$source = new $file_class($instance_arguments);

But this does put the whole $migration->getOption('file_function') parts out of play.

Comments

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Category: bug » support
Status: Active » Postponed (maintainer needs more info)

The file class really does need to be static, not a per-row argument, because each file class has its own set of supported subfields - how would you map the subfields in your constructor?

My preferred approach here would be to have separate MigrateDestinationFile migrations for regular files and Flickr images, then you can easily have a MigrateFileFid class to pull them together (with sourceMigration(array('Files', 'FlickrImages'))).

peteruithoven’s picture

peteruithoven commented

I mapped it like this. 

$this->addFieldMapping('field_media', 'media_filepath');
$this->addFieldMapping('field_media:file_class','media_file_class');
$this->addFieldMapping('field_media:file_replace')->defaultValue('FILE_EXISTS_REUSE');
$this->addFieldMapping('field_media:preserve_files')->defaultValue(FALSE);
$this->addFieldMapping('field_media:source_dir')->defaultValue('files2migrate');
$this->addFieldMapping('field_media:display', 'media_display');    
$this->addFieldMapping('field_media:description', 'images_description');

The media_filepath, media_file_class, media_display and images_description are arrays added as source fields that I fill in prepareRow. In media_filepath I add the filepath to the local files and the url's (inc flickr.com) for flickr images.
This seems to work partly, I get the following messages about timeout's and it doesn't migrate all the items.
simplexml_load_file(http://api.flickr.com/...) [function.simplexml-load-file]: failed to open stream: Operation timed out File .../modules/media/includes/media.xml.inc, line 38

But... that gives me the same problem, how do you define two sourceMigration for one mapping?
This seems like a use case people can run into more often, not Flickr perse but combining multiple file fields into one, could you maybe add an example of how you would map this?

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented

Defining two source migrations for one mapping is just a matter of using an array:

$this->addFieldMapping('field_media', 'media_filepath')
     ->sourceMigration(array('File', 'Flickr'));
$this->addFieldMapping('field_media:file_class')
     ->defaultValue('MigrateFileFid');

Where you have separate MigrateDestinationFile migrations for Flickr references and regular files.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

No further response.