on line 94 the module throws an error if there are no omniture_vars. the code should be wrapped in

<?php
if ($omniture_vars) {
foreach ($omniture_vars as $variable => $value) {
$extra_variables .= "\nvar ".$variable.'="'. $value . '";';
}
}

CommentFileSizeAuthor
#2 omniture.module.patch828 bytesStephenGWills

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

can you provide that as a patch? http://drupal.org/patch/create

Also, it's best to use isset($omniture_vars)

StephenGWills’s picture

StephenGWills commented
Assigned: Unassigned » StephenGWills
Status: Active » Reviewed & tested by the community
StatusFileSize
new omniture.module.patch828 bytes

Patch attached as outlined in the thread.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Fixed

This patch doesn't apply against the "tip" of the DRUPAL-5 branch because this already got fixed and the code was slightly refactored. Can you update and confirm?

Be sure that you are using the DRUPAL-5 branch when you get it from CVS.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)