Posted by StephenGWills on October 9, 2007 at 3:13pm
| Project: | Omniture Integration |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | StephenGWills |
| Status: | closed (fixed) |
Issue Summary
on line 94 the module throws an error if there are no omniture_vars. the code should be wrapped in
<?php
if ($omniture_vars) {
foreach ($omniture_vars as $variable => $value) {
$extra_variables .= "\nvar ".$variable.'="'. $value . '";';
}
}
Comments
#1
can you provide that as a patch? http://drupal.org/patch/create
Also, it's best to use isset($omniture_vars)
#2
Patch attached as outlined in the thread.
#3
This patch doesn't apply against the "tip" of the DRUPAL-5 branch because this already got fixed and the code was slightly refactored. Can you update and confirm?
Be sure that you are using the DRUPAL-5 branch when you get it from CVS.
#4