Posted by xjm

Let's see what happens.

CommentFileSizeAuthor
#16 views-ui-move.patch14.35 KBtim.plunkett
#8 1820414-7.patch8.08 KBdamiankloip
#6 1820414-6.patch7.62 KBdamiankloip
move_views_ui.patch7.17 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Make views_ui.module a sibling of views.module rather than a child » Make views_ui a direct child of modules/
xjm’s picture

xjm
she/her
Primary language English
commented
Title: Make views_ui a direct child of modules/ » Make views_ui a direct child of core/modules/

The only other thing from #1605110: Move views_ui to a subfolder that is potentially relevant anymore is some file locations in the CSS.

damiankloip’s picture

damiankloip commented
Status: Needs review » Postponed

Postponing, we don't need to do this one yet.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Make views_ui a direct child of core/modules/ » Move views_ui.module directly into /core/modules/
Status: Postponed » Needs review

Can we do this now? The nested module tripped me up a couple of times already.

damiankloip’s picture

damiankloip commented

I wouldn't mind, I don't think we have too many views UI patches atm anyway.

damiankloip’s picture

damiankloip commented
StatusFileSize
new 1820414-6.patch7.62 KB

Status: Needs review » Needs work

The last submitted patch, 1820414-6.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 1820414-7.patch8.08 KB

Whoa! not into /core :)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +API clean-up

Thanks!

I expect that to come back green. The only reason for why it shouldn't would be a random test failure, so RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

This makes sense, but let's hold off committing it until after feature freeze since it'll break everything Views-related in the queue.

damiankloip’s picture

damiankloip commented

I'm not sure it would break too many patches at the moment, but I'm easy. The above patch should apply whenever. I can't see us adding more files to views_ui, except tests, but we have #1862352: Move Views UI tests to Views UI module. for that.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: Unassigned » tim.plunkett
Status: Reviewed & tested by the community » Postponed

It would break #1831894: Users miss "save" button and can't distinguish "editable" and "preview" areas, as well as the routing code I just wrote (that I have yet to post an issue for, will do tonight).

damiankloip’s picture

damiankloip commented

Yeah, that's not many. :-)

dawehner’s picture

dawehner
Primary language German
commented

I don't see a win in breaking patches just to move a module :(

damiankloip’s picture

damiankloip commented

I really don't mind when this gets done.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Postponed » Needs review
StatusFileSize
new views-ui-move.patch14.35 KB

Let's just do it.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Fixed

Great!

it's after feature freeze now, and this semi-blocks a critical (#1962130: Fatal Error: ViewUI::isTranslatable endless loop), so I think it's good to go. Sorry, Twig. :\

Committed and pushed to 8.x. Thanks!

dawehner’s picture

dawehner
Primary language German
commented

What a patch without a RTBC?!! Thanks for getting this in.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented

LMAO, I totally missed that this happened and I thought I was losing my mind. Thanks a lot, @tim.plunkett. ;)

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Move views_ui.module directly into /core/modules/ » CHANGE NOTICE: Move views_ui.module directly into /core/modules/
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views_ui.module » Documentation
Assigned: tim.plunkett » Unassigned
Status: Closed (fixed) » Active
Issue tags: +Novice, +Needs change record

Also, I guess this merits a quick change notice.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes

Removing myself from the author field to unfollow the issue. --xjm

chris matthews’s picture

chris matthews commented
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.7.x-dev
Component: Documentation » views.module
Issue summary: View changes

For more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue

chris matthews’s picture

chris matthews commented
Project: Drupal core » Views (for Drupal 7)
Version: 8.7.x-dev » 7.x-3.x-dev
Component: views.module » Code
Status: Active » Closed (outdated)

Moving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447