This is a simple module to show a modal to each new visitor of the website with a facebook like button of any URL or facebook page. Admin page allows the admin to set Facebook page URL, how frequent it should be visible and can set a custom title to the modal. Currently this modules is for Drupal 6.x and Drupal 7.x version will be available soon. This is my first project on Drupal.

Project Page : http://drupal.org/sandbox/judesfernando/1803078
Git repo: git clone http://git.drupal.org/sandbox/judesfernando/1803078.git traffic_pop

Comments

developmenticon’s picture

developmenticon commented
Status: Needs review » Needs work

Welcome,

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Review of the master branch:

developmenticon’s picture

developmenticon commented

Hi,

General

  • Remove LICENSE.txt
  • There is a README.md file, rename to README.txt

traffic_pop.info

  • There is no package defined, try to find or think of one that matches your module the best<

traffic_pop.module

  • Your code does not seem very well commented, please make sure it´s clearly understandable by other developers. Please have a look at the module documentation guidelines and the Doxygen and comment formatting conventions
  • return theme('box','<ul><li>Item 1</li><li>Item 2</li><li>Item 3</li></ul>');: you should do it other way.
  • The JavaScript uses a jquery event instead of Drupal behaviors, it should be changed to use Drupal behaviors
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)