When attempting to add 'display:inline-block' to some elements, I found that it was being entirely stripped out even though the display property was enabled in the filter. I did not find it in wysiwyg_filter_get_style_property_groups(), so I've added it. Thanks in advance.

CommentFileSizeAuthor
#1 wysiwyg_filter-allow_display_inline_block-1821084-2.patch1.11 KBvinmassaro

Comments

vinmassaro’s picture

vinmassaro commented
Status: Active » Needs review
StatusFileSize
new wysiwyg_filter-allow_display_inline_block-1821084-2.patch1.11 KB
golddragon007’s picture

golddragon007 commented
Issue summary: View changes
Status: Needs review » Needs work

Yes, this patch allow inline-block, however, I think this is not the right way, good solution. I don't know what want to do this: '(?:inline-)?table' (I think this allow only inline-table and table), but I'm nearly sure all inline-* are filtered out. So more likely you need to create an expression like this:
table-(?:(?:row|header|group|column)-group|row|column|cell|caption)
And also I think we can allow all inline-* attributes...

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Needs work » Reviewed & tested by the community

#1 only adds inline-block to the line so #2 does not talk about the patch.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: wysiwyg_filter-allow_display_inline_block-1821084-2.patch, failed testing. View results

  • axel.rutz committed 82073fd on 7.x-1.x authored by vinmassaro 
    Issue #1821084 by vinmassaro: Allow display: inline-block (patch...
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.