Disqus SSO login goes to disqus.com/user/login instead of my site user/login like FFand Chrome.
Is anyone else having or had this issue?
This only happens in ie8 & ie9 when using disqus 2012 not the older disqus.

Comments

standingtall’s picture

Same issue here ..

Will appreciate if someone can help!!

no sssweat’s picture

Hey guys, I found a solution!!!

edit the disqus.module file

online 144 change

url ('user/login TO url ('http://yourwebsite.com/user/login

slashrsm’s picture

It would be nice to fix this in HEAD. Anyone willing to prepare a patch?

no sssweat’s picture

what do you mean by "HEAD" ?

no sssweat’s picture

UGH!! just found out that my solution in #2 won't work with Firefox, works fine with IE and Chrome.

no sssweat’s picture

...

no sssweat’s picture

Issue summary: View changes
Status: Active » Fixed

This is fixed in 7.x-1.10

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bromsulaiman’s picture

Hey guys,

Sorry to open this one again, but I'm having the same issue. I'm using the latest version 7.x-1.10.

Here's an example of the issue on our site: http://www.theleadershiphub.com/blogs/3-ways-strengthen-your-bench-next-...

If you click our logo in the Disqus comment block it opens this URL: http://disqus.com/user/login?destination=disqus/closewindow

Am I missing something?

bromsulaiman’s picture

Status: Closed (fixed) » Needs work
bromsulaiman’s picture

Version: 7.x-1.9 » 7.x-1.10
slashrsm’s picture

Status: Needs work » Needs review
StatusFileSize
new863 bytes

Does this fix the problem?

bromsulaiman’s picture

Fantastic, that fixed it for me! Appreciated.

slashrsm’s picture

Version: 7.x-1.10 » 8.x-1.x-dev
StatusFileSize
new3.68 KB

Great! This needs to go in D8 first.

JayeshSolanki’s picture

StatusFileSize
new3.73 KB

Small fix for the above patch: added 'toString()' to convert the URL object to uri. Tested it too, works fine

slashrsm’s picture

Status: Needs review » Reviewed & tested by the community

I believe this is ready to go. Both D8 and D7 patches.

Please add interdiff next time. https://www.drupal.org/documentation/git/interdiff

JayeshSolanki’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new3.74 KB
new715 bytes

this should be it. interdiff with #16

slashrsm’s picture

You sure that is needed? Isn't route expecting object instead of raw id?

JayeshSolanki’s picture

Yes I think so. Passing the object gave me an error as "Warning: preg_match() expects parameter 2 to be string, object given ......"
and since the 2nd parameter to Url::fromRoute requires route_parameters, passing array("user" => $account->id()) sounds right.
Also var_dump()ed the variable and checked, it has the expected link.

slashrsm’s picture

Status: Needs review » Reviewed & tested by the community

OK then :)

  • JayeshSolanki committed ce024b4 on 7.x-1.x authored by slashrsm
    #1821146 by DElion, slashrsm, JayeshSolanki: Fixed SSO login, which was...
JayeshSolanki’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.