Closed (fixed)
Project:
Disqus
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Oct 2012 at 20:17 UTC
Updated:
6 Jan 2015 at 10:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
standingtallSame issue here ..
Will appreciate if someone can help!!
Comment #2
no sssweat commentedHey guys, I found a solution!!!
edit the disqus.module file
online 144 change
url ('user/loginTOurl ('http://yourwebsite.com/user/loginComment #3
slashrsm commentedIt would be nice to fix this in HEAD. Anyone willing to prepare a patch?
Comment #4
no sssweat commentedwhat do you mean by "HEAD" ?
Comment #5
slashrsm commentedhttp://stackoverflow.com/questions/2304087/what-is-git-head-exactly
Comment #6
no sssweat commentedUGH!! just found out that my solution in #2 won't work with Firefox, works fine with IE and Chrome.
Comment #7
no sssweat commented...
Comment #8
no sssweat commentedThis is fixed in 7.x-1.10
Comment #10
bromsulaiman commentedHey guys,
Sorry to open this one again, but I'm having the same issue. I'm using the latest version 7.x-1.10.
Here's an example of the issue on our site: http://www.theleadershiphub.com/blogs/3-ways-strengthen-your-bench-next-...
If you click our logo in the Disqus comment block it opens this URL: http://disqus.com/user/login?destination=disqus/closewindow
Am I missing something?
Comment #11
bromsulaiman commentedComment #12
bromsulaiman commentedComment #13
slashrsm commentedDoes this fix the problem?
Comment #14
bromsulaiman commentedFantastic, that fixed it for me! Appreciated.
Comment #15
slashrsm commentedGreat! This needs to go in D8 first.
Comment #16
JayeshSolanki commentedSmall fix for the above patch: added 'toString()' to convert the URL object to uri. Tested it too, works fine
Comment #17
slashrsm commentedI believe this is ready to go. Both D8 and D7 patches.
Please add interdiff next time. https://www.drupal.org/documentation/git/interdiff
Comment #18
JayeshSolanki commentedthis should be it. interdiff with #16
Comment #19
slashrsm commentedYou sure that is needed? Isn't route expecting object instead of raw id?
Comment #20
JayeshSolanki commentedYes I think so. Passing the object gave me an error as "Warning: preg_match() expects parameter 2 to be string, object given ......"
and since the 2nd parameter to Url::fromRoute requires route_parameters, passing
array("user" => $account->id())sounds right.Also var_dump()ed the variable and checked, it has the expected link.
Comment #21
slashrsm commentedOK then :)
Comment #24
JayeshSolanki commented