comment stats don't update after approval in moderation queue

Apologies for the extra e-mail. The previous patch file was not done correctly. Here's a diff against Revision 1.302.2.9, the last 4-5-2 tagged version of the module as of this post.

-Ankur

Here's an alternative patch. This patch changes comment_admin_edit():

Previously, the function would check to see if edits to the comment were being $_POSTed().
If this was the case, there would be a call to comment_save() and then a drupal_goto() back to q=admin/comment.
Otherwise, the comment would be loaded and an edit form would be displayed.

The problem was that the comment count for the related node was not being updated and that in order to do so, you have to know the nid of the comment (the single parameter to _comment_update_node_statistics()).

However, the form being posted did not contain the nid for the comment. The previous patch passed the nid (and prior publish status of the comment) through the form via hidden HTML form fields.

With this patch, the loading of the comment is done first. After, loading the comment, we check to see if changes to the comment are being $_POSTed. Then we save and see if _update_comment_node_statistics() should be called.

This patch is a way around having to pass hidden fields. However, the drawback (and I can't really quantify how serious of a performance penalty this would mean) is that a comment has to be loaded again when changes are submitted whereas with the previous patch, changing the comment would just mean saving the comment without having to reload it (since the nid and previous status were passed via hidden fields).

In anycase, I don't know if there's another solution around this without causing some more major changes. Frankly, it would be cool if the update node could distinguish the approved comment as "1 new comment" rather than "1 comment". But then that would require some way of telling whether a comment was being approved for the first time or if the comment was edited and resubmitted to the approval queue...

-Ankur

I'm submitting 2 more patches here.

I didn't realize that comment_save() made the call to _comment_update_node_statistics().

Well, I took a look at comment_save() and realize that it passes $edit['nid'] as the single parameter to _comment_update_node_statistics().

Now, comment_admin_edit() passes $edit to comment_save() as the 2nd param. The problem now is that there is no 'nid' key in the $edit that is passed to comment_save().

This patch avoids passing the nid as a hidden field. It works similarly to the 2nd patch I submitted above by moving the comment loading to the beginning of comment_admin_edit() and then figuring out what to do (in terms of displaying the edit-form vs. saving an edit and redirecting back to q=admin/comment). It was noted above that hidden fields in this case are to be avoided. This patch doesn't do that, but the next follow-up by me has a patch that does it. I think that's the way to go (see below).

-Ankur

This patch does what the very first patch does, only now I know that comment_save() itself calls _comment_update_node_statistics(). Again, the problem is that the $edit parameter that is passed from comment_admin_edit() to comment_save() does not contain a value for key 'nid'. This is a problem because comment_save() calls _comment_update_node_statistics() and passes $edit['nid'] as the single parameter to _comment_update_node_statistics().

There was a comment above against fixing this error by passing the 'nid' as a hidden field on the comment_admin_edit() page. However, we already pass the comment's 'cid' as a hidden field. We need to pass the 'nid' to comment save as well. My feeling is that this is the logical way as it is consistent with how the 'cid' is transmitted and saved...

-Ankur