Closed (fixed)
Project:
Drupal core
Component:
node.module
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
1 Mar 2005 at 22:54 UTC
Updated:
21 Mar 2005 at 22:15 UTC
Jump to comment: Most recent file
I have noticed this morning that hook_nodeapi is no longer called by $node as first argument as first setting, but only $type. I documented this in the handbook, 'cos I have thought this is well thought out decision which is executed through the core. But only node.module is updated, comment and upload is broken and every node module out there. I know we do not have backwards compatibility. I think it would be better to introduce a new hook for this. But, as we are in feature freeze, I doubt any of this shall happen. Instead, for now let's change the behaviour back.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | nodeapi_settings_2.patch | 2.92 KB | asimmonds |
| nodeapi_settings.patch | 2.49 KB | chx |
Comments
Comment #1
chx commentedhttp://drupal.org/node/16384
Comment #2
chx commentedResetting to patch, as Dries just commented this as 'slightly better'.
Comment #3
asimmonds commentedSlightly updated patch that now does both $node->type references in the form_checkboxes call, and the change to the phpDOC.
Comment #4
asimmonds commentedErr, somethings funny with the issue version field, changing back to cvs.
Comment #5
dries commentedCommitted to HEAD.
Comment #6
(not verified) commented