There is some code on the JoinPluginBase, which is broken because it resets $this->extra instead of this->adjusted.

    if (!empty($configuration['extra'])) {
      $this->extra = $configuration['extra'];
    }

    if (isset($configuration['adjusted'])) {
      $this->extra = $configuration['adjusted'];
    }

This issue requires a test together with the fix.

CommentFileSizeAuthor
#1 views_replacement_joinplugin_1822384_1.patch1.55 KBHanspolo

Comments

Hanspolo’s picture

Hanspolo commented
Status: Active » Needs review
StatusFileSize
new views_replacement_joinplugin_1822384_1.patch1.55 KB

Here is a patch.
Extra is not overwritten now.

I added some tests that check that the constructor sets the values correct.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Awesome! This somewhere blocked another issue, but i don't remember ( i think comment as field probably).

Status: Reviewed & tested by the community » Needs work
Issue tags: -Needs tests, -Novice, -VDC

The last submitted patch, views_replacement_joinplugin_1822384_1.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review

#1: views_replacement_joinplugin_1822384_1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs tests, +Novice, +VDC

The last submitted patch, views_replacement_joinplugin_1822384_1.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Reviewed & tested by the community

Back to RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

OK this is a one-liner with a test change, so committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.