This is a project that will make it possible for Drupal 7 users to attach an image to each menu item as desired.

Basically, the module adds a fieldset that exposes, at the very least, a image upload field much like the one used for adding a picture to user accounts.

The main purpose of the module is to have the ability to display the attached image as icon for the menu item, or as full main clickable body of the menu item if the menu link title is not displayed.

We have a short term plan for adding the option of using one of the following options:

  • Rendering mode: [Image only|Text only|Image and text]
  • Make the image clickable: [Yes|No]
  • Image position: [Before|After]
  • Image style: [....]
  • Inherit from parent menu item
  • etc.

The module will later have a detailed configuration page that will allow specifying various global settings. It presently makes use of the "image style" function provided by the core to render the images in a consistent manner.

The project's page is https://drupal.org/sandbox/asiby/1805518

You can "git" :) the project's code at ...
git clone --recursive --branch 7.x-1.x asiby@git.drupal.org:sandbox/asiby/1805518.git menu_item_image

The module is targeting Drupal 7.

Drupal 6 is not supported yet unless there is a huge demand for it. In fact, I am not sure if we are allowed to create new Drupal 6 modules given that Drupal 8 in being cooked. If so, I will gladly start analyzing the possibilities.

I haven't reviewed any other modules yet, but I will soon. I am trying to read about and gather all the tools that are needed by a reviewer.

Cheers.

Comments

riho’s picture

riho commented

Hi and welcome,

Fix your git clone line, the current one will ask for your password, the one on your project page is the correct one.

Also take a look at the errors found by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxasiby1805518git

Good luck with your module!

riho’s picture

riho commented
Status: Needs review » Needs work
developmenticon’s picture

developmenticon commented

It seems that http://drupal.org/project/menu_icons provides very similar functionality. Could you describe how your module differs?
We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

asiby’s picture

asiby commented

Thanks guys.

@developmenticon is correct. The menu_icons modules (http://drupal.org/project/menu_icons) is providing a similar function. I can't believe I didn't see it before.

What happens if the fellows in charge of menu_icons refuse to let me contribute to their module? All the development I do is made with accessibility in mind. However, I know that many people out there do not care much about accessible web solutions.

I am willing to avoid duplicating effort and stop developing this module. However, they are creating the menu items' background images using CSS. My module is printing inline images with the option of showing the image alone (it was the next step). Since the image is inline, it will be just file when the web page is printed. I am not sure if those differences are sufficient to justify the creation of a separate module, but I certainly hope so as it will quickly prove a concept. In the mean time, I will contact the menu_icons' developers to try to merge the two module under the menu_icons' label (it's been around for a longer time).

I have a question for you. What tools are you guys using for reviewing the code. You seem to be able to find tons of errors when the coder module has reported that the module was clean.

Cheers

asiby’s picture

asiby commented

The git clone line is: git clone http://git.drupal.org/sandbox/asiby/1805518.git menu_item_image

asiby’s picture

asiby commented
Status: Needs work » Needs review

The code in the master branch has been moved to 7.x-1.x and all the known issues fixed.

developmenticon’s picture

developmenticon commented

There are several contributed modules/projects available to assist with review for coding standards compliance:

  • Coder module, which includes both Coder Review (reviews) and Coder Upgrade (updates your code). To use it:
    1. Install the module (like any other module)
    2. Click on the "Code Review" link in your navigation menu.
    3. Scroll down to "Select Specific Modules".
    4. Select the module you wish to review, and click the "Submit" button.

    As an alternative to starting from the Code Review link in navigation, you can also review a particular module's code by clicking on the link on the Modules admin screen.

  • Dreditor (a browser plug-in for reviewing patches and more)
  • PARevview (a set of scripts for reviewing project applications, which runs some coding tests)
  • Drupal Code Sniffer (runs coding standards validation without loading drupal)
  • The Grammar Parser module provides an automated way of rewriting code files in compliance with code standards. You'll probably also need the Grammar Parser UI module.

This video may help you about the code review process and tools:
http://munich2012.drupal.org/program/sessions/project-application-review....

Thanks,
Himanshu Shakhar

indydas’s picture

indydas commented

Hi there,

Interesting module this but kind of makes sense moving all work to the other module! Keen to track progress on the other one now. :)

cubeinspire’s picture

cubeinspire commented
Status: Needs review » Postponed (maintainer needs more info)

This looks like the same functionality than http://drupal.org/project/menu_icons module. Module duplication and fragmentation is a huge problem on drupal.org, so please open an issue in the twitter queue and get in contact with the maintainers.

If that fails for whatever reason please get back to us and set this back to "needs review".

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)