Unless this fix is implemented unpublishing means nothing and there is no way to hide Feed/Item nodes.

CommentFileSizeAuthor
simplefeed_0.patch1.12 KBdkruglyak

Comments

m3avrck’s picture

Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

That patch isn't correct as it never allow anyone to view unpublished nodes.

What seems to the problem in terms of unpublished ones showing up?

dkruglyak’s picture

Status: Postponed (maintainer needs more info) » Needs work

Not quite, since admin will always see the nodes. But in any case, why does anyone need to view unpublished nodes? The author can still view them in edit mode and publish them if needed.

If you think it is really needed, perhaps we could make the nodes always viewable by author and/or create a permission to view unpublished nodes and adjust the logic accordingly. But in my view this is an unnecessary complication.

The current behavior of being unable to hide feed(item) nodes is far worse - as this is the case often needed to manage undesireable aggregated items without deleting them.

m3avrck’s picture

Well you need to make sure your view or your query that is showing feeds is only showing ones where status = 1.

The refresh queries are only refreshing feeds that are published.

If you see these feeds on your site then your SQL is broken somewhere else.

dkruglyak’s picture

Fixing views to add status = 1 is not enough. This would only remove the node from lists, while if accessed directly by URL unpublished nodes would be still viewable. This makes it impossible to hide nodes, e.g. from web search.

This has nothing to do with broken SQL.

m3avrck’s picture

Status: Needs work » Fixed

This has been fixed. Simplefeed no longer interferes with view access (and it shouldn't). Committed a different patch to remove code.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.