When you attach some events on a submit button in a form within a ctools modal, event is not triggered because the form submit is triggered from modal.js.
The previous fix was for jquery 1.4 so we added a test for triggering the previous patch only in a jQuery 1.4 context (the bubbling is fixed in jQuery 1.4.4).

CommentFileSizeAuthor
#9 eventBubblingBugIE8-1823088-9.patch643 bytesmrjmd
#7 eventBubblingBugIE8-1823088-7.patch634 bytesmrjmd
#5 eventBubblingBugIE8-1823088-5.patch634 bytesmrjmd
#1 eventBubblingBugIE8-1823088-1.patch654 bytesilyna

Comments

ilyna’s picture

ilyna commented
Status: Active » Patch (to be ported)
StatusFileSize
new eventBubblingBugIE8-1823088-1.patch654 bytes
artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented
Version: 7.x-1.2 » 7.x-1.x-dev
Status: Patch (to be ported) » Needs review

DamienMcKenna queued 1: eventBubblingBugIE8-1823088-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: eventBubblingBugIE8-1823088-1.patch, failed testing.

mrjmd’s picture

mrjmd commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new eventBubblingBugIE8-1823088-5.patch634 bytes

Re-roll attached.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

The comment needs proper wrapping at line 80, and shouldn't the "==" comparison be "===" instead?

mrjmd’s picture

mrjmd commented
Status: Needs work » Needs review
StatusFileSize
new eventBubblingBugIE8-1823088-7.patch634 bytes

The comment was only 78 chars long I think, but I went ahead and re-organized it, changed "binded" to "bound", and "==" to "===".

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

Another small correction, the code should actually be: typeof myVar === "undefined"

mrjmd’s picture

mrjmd commented
Status: Needs work » Needs review
StatusFileSize
new eventBubblingBugIE8-1823088-9.patch643 bytes

Yep, I was wondering about that too. Here's another try.

parisek’s picture

parisek
Primary language Czech
commented
Related issues: +#2427281: Support for newer jquery versions in modal.js

Proposed patch resolved issue with editablefields in modal window. Similar issue was reported in https://www.drupal.org/node/2427281

I think patch in #9 is good candidate to be committed soon

njbarrett’s picture

njbarrett commented
Status: Needs review » Reviewed & tested by the community

Patch #9 fixed the issue for me. This should definitely be commited.
Autosubmits in modals are broken without it.

njbarrett’s picture

njbarrett commented
Title: JS event bubble error on IE8 with jQuery 1.4.4 » Autosubmit forms in modals are broken
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2423731: Plan for CTools 7.x-1.8 release

njbarrett queued 9: eventBubblingBugIE8-1823088-9.patch for re-testing.

japerry’s picture

japerry
Location KOMK
commented

why did undefined turn into "undefined" ?? or does that matter?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@japerry: Because that's how you're supposed to do it: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operat...

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2423731: Plan for CTools 7.x-1.8 release » #2554339: Plan for CTools 7.x-1.10 release

Moving this to the v7.x-1.10 release plan.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Ahh makes sense. Committed.

  • japerry committed 77ce35d on 7.x-1.x authored by mrjmd 
    Issue #1823088 by mrjmd, kynaa: Autosubmit forms in modals are broken

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

othermachines’s picture

othermachines commented

Just alerting you all to a possible bug related to this fix: #2787045: Regression: Compatibility with Drupal 7 core version of jQuery broken .

jastraat’s picture

jastraat commented
Related issues: +#2787045: Regression: Compatibility with Drupal 7 core version of jQuery broken