During the process of embedding a file into a textarea using Media's WYSIWYG integration, Media: Vimeo currently checks to see if the file being embedded has the mimetype video/vimeo and then "bypasses" the view mode selection form by automatically submitting the form.

This functionality should be removed for a number of reasons:

  • It limits the user from displaying multiple versions of their content (a "large" video on one page and a "preview" on another).
  • It's confusing to the user; why is a view mode selector available for every other type of media.
  • The ability to automatically submit the view mode form may be removed by #1301774: Remove some legacy popup browser code.

This is also currently not working since Media: Vimeo checks for the mimetype video/vimeo which is not available (see #1823078: Create video/vimeo mimetype).

CommentFileSizeAuthor
#1 remove-view-mode-autosubmit-1823426-1.patch644 bytesdevin carlson

Comments

devin carlson’s picture

devin carlson commented
Status: Active » Needs review
StatusFileSize
new remove-view-mode-autosubmit-1823426-1.patch644 bytes

A patch to remove the view mode autosubmit.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

I just commited #1301774: Remove some legacy popup browser code. Ideally this should be fixed before media unstable7

gmclelland’s picture

gmclelland commented

Is this still an issue? Using the lastest dev version of Media, File Entity, and Media Vimeo, I successfully inserted a vimeo video using the WYSIWYG media browser button the choosing the "Web" tab and pasting my link. Then it displays a view mode selector.

RobW’s picture

RobW commented

Pretty sure I fixed this a while back. Haven't touched the code in a while, so confirmation would be nice before this issue is closed.

devin carlson’s picture

devin carlson commented

The code is still in 7.x-2.x.

It doesn't have any effect since #1301774: Remove some legacy popup browser code was fixed in http://drupalcode.org/project/media.git/commit/ff6c938.

RobW’s picture

RobW commented

Looks like I only took care of this for M:YT. Patch in #1424120: Setting autosubmit breaks core media functionality removes only the autosubmit. I don't think the code in #1301774: Remove some legacy popup browser code removes the settings object entirely, just the autosubmit handling. I believe we're not using settings now, but I'm leaning towards the patch in the 1424 issue incase we do in the future. Although if we did, we could just add the set settings line back in (thinking out loud here). Thoughts?

drupal_was_my_past’s picture

drupal_was_my_past commented
Status: Reviewed & tested by the community » Needs review

The patch from #1424120: Setting autosubmit breaks core media functionality solves this issue for me. +1 RTBC

RobW’s picture

RobW commented

OK, now that I have time to think about it, it's obvious we should remove the settings code as well, as the patch in this issue does. Moving back to RTBC, and I'll commit it in a day or two.

RobW’s picture

RobW commented
Issue summary: View changes

Grammar

devin carlson’s picture

devin carlson commented
Issue summary: View changes
Status: Needs review » Fixed

This was fixed as part of a general cleanup of the .module file.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.