Closed (fixed)
Project:
Examples for Developers
Version:
7.x-1.x-dev
Component:
Tabledrag Example
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Oct 2012 at 08:05 UTC
Updated:
18 Dec 2012 at 19:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
mile23Thanks for running the module through your magic compliance machine. :-)
Just a few things..
Not all empty lines are wrong. I think that's a natural break in the flow of the comments, though it's debatable of course.
This should really be a @code directive. http://drupal.org/coding-standards/docs#code
Comment #2
mile23Hmm. Dreditor seems to have the hiccups.
Comment #3
amitgoyal commented@Mile23 - Please find attached updated patch based on your suggestions.
Comment #4
mile23Coder found another one that I took care of:
tabledrag_example_parent_form.inc
Line 177: Functions should be called with no spaces between the function name and opening parentheses
unset ($form['example_items'][$id]['depth']);
Also: No tests for tabledrag_example. Sob. Since this is a coding standards issue though, I'll fire up another issue.
Looks great, amitgoyal. Thanks. :-)
Committed: http://drupalcode.org/project/examples.git/commitdiff/bf73ec93d5e85cb4b2...
Comment #5
mile23