Posted by jhodgdon on October 26, 2012 at 1:06pm
5 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | node.module |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | Novice |
Issue Summary
There's a method NodeBlocktest::testSearchFormBlock() which actually tests the syndicate block, not the search form block. It really should be renamed. This is in core/modules/node/lib/Drupal/node/Tests/NodeBlockTest.php.
Comments
#1
Let me give a try to fix it.
#2
I renamed the method to
function testSyndicateBlock() {..
#3
That seems like a much more reasonable name. Thanks! This should be fine assuming the test bot agrees.
#4
Uh, yes! Those two things aren't the same thing at all, are they? :)
Committed and pushed to 8.x. Thanks!
#5
Actually, it looks like this one could use a backport to d7 -- node.test has the NodeBlockTestCase class with the same method name in it.
#6
I fixed that for d7 too. Created that patch on 7.x-dev version.
#7
The last submitted patch, confusing_name-1824016-6.patch, failed testing.
#8
That's not a 7.x patch -- there is no core directory in 7.x.
#9
Yes obviously i was wrong. I am still learning git but i should have seen that by myself. Heres another patch for d7.
#10
Thanks! That patch looks right to me. I'll get it committed this week (avoiding non-essential core commits this week due to a big Views sprint going on).
#11
Thanks! 7.x is now one word clearer. :) Oops. I guess this wasn't strictly documentation, but it's a clean-up and backport of a committed 8.x patch. Hope it's OK that I committed it. ...
#12
Automatically closed -- issue fixed for 2 weeks with no activity.