Project description

A detailed description is available at the project page.

In short, this module automates APC opcode cache flushing. Its is mainly usefull when used in a production setup with multiple webservers that use apc.stat=0.

Similar modules

One might think this functionality belongs to the apc-module, but its not really related. That module provides APC user cache as a backend (like memcache) for drupal, but doesn't do anything with opcode caches, which is was ~ 9x% of PHP setups use.

I couldn't find any module that deals specifically with APC opcode flushing - or rather, apc.stat=0 setups AND multiple webservers.

Drupal version

The module works with Drupal 7 and drush.

Git

Current (7.x-1.x) version can be fetched with:
git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/bibo/1823868.git apc_flush

Module reviews

I have done some reviews in the last few years. Will create at least one more review and link them here.

Comments

bibo’s picture

bibo commented

Don't review this just yet. I'll fix the coding standard issues first. Thanks.

bibo’s picture

bibo commented

A review I've made in the past:
* Cache Control

hernani’s picture

hernani commented

@Bibo,

Have you considered protecting the callback to clear local APC cache with drupal_get_token instead of defining a secret key that does not change overtime?

You could use url() function in several contexts, instead of building your own paths:

 108     $flush_url = base_path(). drupal_get_path('module','apc_flush') . '/apc_flush.php?ts=' . REQUEST_TIME;
 109     // Downside: cant use secret or logging since there is no db connection and we want to keep this simple.
 110   }else{
 111     $flush_url = '/apc-flush?s=' . $secret . '&ts=' . REQUEST_TIME;
aritra.ghosh’s picture

aritra.ghosh commented
Status: Needs review » Needs work

Hii,

Quick manual Review:

1. Please remove versions from .info file. It will be automatically added by Drupal during packaging.

Please make sure to run your module and correct the errors through drupal automatic code sniffer. Currently is shows a large number of them: http://ventral.org/pareview/httpgitdrupalorgsandboxbibo1823868git

Here are the highlights of the result of automatic code review:
1. Line exceeds 80 characters
2. File and Function header missing.
3. Indentation issues

changing the status to needs work.

Thanks,
Aritra

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

bibo’s picture

bibo commented
Status: Closed (won't fix) » Postponed

Sorry for being inactive. I will return working on the module and re-open this sometime during this month.

PA robot’s picture

PA robot commented
Status: Postponed » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented
Issue summary: View changes

made git link readable and .. corrected my english