This is a sub-task of http://drupal.org/node/1775842 Convert all variables to state and/or config systems.

CommentFileSizeAuthor
#5 1824768-update_drupal_test_email_collector-5.patch2.92 KBvijaycs85
#3 update_drupal_test_email_collector-4.patch2.92 KBvijaycs85
#2 update_drupal_test_email_collector.patch2.9 KBvijaycs85

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Title: Convert update_last_check and update_last_email_notification variables to CMI system » Convert drupal_test_email_collector variable to CMI system
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
StatusFileSize
new update_drupal_test_email_collector.patch2.9 KB
vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new update_drupal_test_email_collector-4.patch2.92 KB

Fixing variable name

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Needs work 
+++ b/core/lib/Drupal/Core/Mail/VariableLog.phpundefined
@@ -21,9 +21,9 @@ class VariableLog extends PhpMail implements MailInterface {
-    $captured_emails = variable_get('drupal_test_email_collector', array());

Lets namespace the state variable to system.test_email_collector

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 1824768-update_drupal_test_email_collector-5.patch2.92 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks for the work!

There's no need for an hook_update_N function as this is only used in tests.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Assigned: vijaycs85 » Unassigned
Issue summary: View changes