Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
theme system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Oct 2012 at 17:31 UTC
Updated:
29 Jul 2014 at 21:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
cameron tod commentedComment #2
cameron tod commentedHere we go.
Comment #3
aspilicious commentedWhat does theme_link do?
Comment #4
cameron tod commentedl() can either render links inline, or pass through theme_link() Rendering a link inline in l() is faster than using theme_link(). Because l() is so heavily used, using theme_link() can add a lot of overhead to page views, so by setting theme_link to FALSE you can disable theme_link entirely.
Here's the inline comment:
You can see this comment for effulgentsia's numbers on this.
Comment #5
aspilicious commentedOk for me this is good to go in that case.
Comment #6
catchI'm not sure this should go in the same place as the list of enabled themes, it seems a bit mis-placed there. Bumping back to CNR.
Comment #7
cameron tod commentedMoved into system.performance.
Comment #8
cameron tod commentedUm, don't know what is up with that interdiff :/
Comment #9
catchsystem.performance is a great idea for this one!
Comment #10
catch#7: 1824920-cmi_convert-theme-link-variable-7.patch queued for re-testing.
Comment #12
cameron tod commentedOK, will reroll.
Comment #13
cameron tod commentedComment #15
justafishBumping system update number
Comment #16
aspilicious commentedNumber is way higher again! Srry!
Comment #17
cameron tod commentedRerolled against current head, bumped update number even higher.
Comment #19
cameron tod commentedThe same test is failing here, but I have rerolled with a new system update in the meantime. Investigating.
Comment #21
cameron tod commentedThanks to timplunkett for the help!
Comment #22
cameron tod commentedHere's an interdiff of the changes to the test that was failing before.
Comment #23
ACF commentedLooks good to go, agreed it should be in performance.
Comment #24
catchCommitted/pushed to 8.x, thanks!
Comment #25
sunComment #26
xjmMissed an update hook addition.
Comment #27
xjmlol. Crosspost.
Comment #28
catchWhoops. I credited both of yer.
Comment #29
xjmThanks!
Comment #30.0
(not verified) commentedwas linking to wrong meta issue