The bgiframe jquery plugin applies to IE 6 only.

related #1507960: [meta] Isolate and/or remove IE-specific hacks in core markup, CSS and JavaScript

CommentFileSizeAuthor
#1 remove-bgiframe-jquery-plugin-1825236.patch2.37 KBandrew_mallis

Comments

andrew_mallis’s picture

andrew_mallis commented
Status: Active » Needs review
StatusFileSize
new remove-bgiframe-jquery-plugin-1825236.patch2.37 KB

(my first core) patch attached.

devin carlson’s picture

devin carlson commented
Status: Needs review » Reviewed & tested by the community

The patch in #1 applies cleanly and removes both the bgiframe plugin and its copyright notice.

I agree that the plugin can be removed since D8 doesn't support IE6 which is the only browser that bgiframe targets.

catch’s picture

catch
he/him
Primary language English
commented
Assigned: Unassigned » nod_
Status: Reviewed & tested by the community » Needs review

It's my understanding we update jQuery UI all in one go, so the next patch to update that would automatically revert this. Putting this in nod_'s queue in case he's got thoughts on this. The plugin isn't used anywhere so this is just dead code atm.

nod_’s picture

nod_
Primary language French
Location Lille
commented

bigframe ships with jquery UI (it is also in UI 1.9) so no we shouldn't be removing it. It's not declared as part of our library definition so no need to remove that either.

I agree that it's dead code but it's not our dead code.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Closed (works as designed)

Thanks. Marking as works as designed.

andrew_mallis’s picture

andrew_mallis commented

anything in /core/misc APPEARS as our dead code.

If it's not our responsibility, shouldn't these element live in /core/vendor ?

nod_’s picture

nod_
Primary language French
Location Lille
commented

I agree. unfortunately the PHP / psr-0 people don't.