Needs template_preprocess and template

CommentFileSizeAuthor
#3 convert-theme_node_search_admin-to-twig-1825690-3.patch2.01 KBWebDevDude
#1 convert_theme_node_search_admin-1825690-1.patch1.78 KBWebDevDude

Comments

WebDevDude’s picture

WebDevDude commented
Status: Active » Needs review
StatusFileSize
new convert_theme_node_search_admin-1825690-1.patch1.78 KB

This patch was created following the work submitted in other patches, so I'm not sure if doing a preprocess on both 'table' and 'form' is necessary.
If both variables should be provided to the twig template, are these valid descriptions?

table: The table of the settings.
form: The submit button.

Thank you.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Needs work
Issue tags: +Needs documentation updates 
+++ b/core/themes/stark/templates/node/node-search-admin.html.twigundefined
@@ -0,0 +1,17 @@
+* - table: The table of the settings?????
+* - form: The Submit button??????

this needs better documentation

all other looks good

WebDevDude’s picture

WebDevDude commented
StatusFileSize
new convert-theme_node_search_admin-to-twig-1825690-3.patch2.01 KB

Thanks @podarok.

Updated documentation:

before:

+* Available variables:
+* - table: The table of the settings?????
+* - form: The Submit button??????

now:

+* Available variables:
+* - table: The table of the settings.
+* - form: A render element representing the form.
WebDevDude’s picture

WebDevDude commented
Status: Needs work » Needs review

Updating Status.

jenlampton’s picture

jenlampton
she / her
commented
Component: Twig templates » Twig templates (front-end branch)
Status: Needs review » Needs work

A template file that contains 

{{ table }}
{{ form }}

Isn't useful to font end devs. There's no markup in here. At the very least we should be calling theme('table') from inside this template, and passing in the appropriate variables.

I'm going to commit this as-is so that we can get something working in the sandbox, but we should revisit how to handle these components later on.

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 1750250)