Download & Extend

Add module owner to plugin data on display handlers

Project:Drupal core
Version:8.x-dev
Component:views.module
Category:task
Priority:normal
Assigned:Unassigned
Status:needs review
Issue tags:DX (Developer Experience), VDC

Issue Summary

Similar to #1810480: Provide the plugin_id to support views metadata integration, we will benefit from also having the module that implemented or owns the plugin.

This is in preparation for what we will do with broken/missing handlers. Which is also related to #1823608: Admin views in core.

Comments

#1

Title:Add implementing module to plugin data on display handlers» Add module owner to plugin data on display handlers

#2

This should be very quick to implement, we just add this to addItem.

Now we just need to add this to all the current YAML files.... *Looks at dawehner*

AttachmentSizeStatusTest resultOperations
1825896.patch913 bytesIdleFAILED: [[SimpleTest]]: [MySQL] 46,350 pass(es), 4 fail(s), and 0 exception(s).View details | Re-test

#3

Status:active» needs review

Updated all the yml files with the script in the attachment.

Just linking an issue with does something related but at the exact space in code. #1810480: Provide the plugin_id to support views metadata integration

AttachmentSizeStatusTest resultOperations
scripts.txt1.34 KBIgnoredNoneNone
drupal-1825896-3.patch55.71 KBIdleFAILED: [[SimpleTest]]: [MySQL] 46,365 pass(es), 5 fail(s), and 0 exception(s).View details | Re-test

#4

Status:needs review» needs work

The last submitted patch, drupal-1825896-3.patch, failed testing.

#5

Status:needs work» needs review

Let's postpone this on #1810480: Provide the plugin_id to support views metadata integration as it requires the same kind of assertions.

AttachmentSizeStatusTest resultOperations
drupal-1825896-5.patch53.87 KBIdleFAILED: [[SimpleTest]]: [MySQL] 46,380 pass(es), 5 fail(s), and 0 exception(s).View details | Re-test

#6

Status:needs review» postponed

.

#7

Status:postponed» active

As per #5

#9

Status:active» needs review

Here is an initial patch, which also fixes some of the yml files, so my script could work.

AttachmentSizeStatusTest resultOperations
drupal-1825896-9.patch95.99 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1825896-9.patch. Unable to apply patch. See the log in the details link for more information.View details | Re-test
test.txt1.22 KBIgnoredNoneNone

#10

Status:needs review» needs work

The last submitted patch, drupal-1825896-9.patch, failed testing.

#11

Status:needs work» needs review

Just a rerole. (frontpage got changed)

AttachmentSizeStatusTest resultOperations
drupal-1825896-11.patch95.97 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1825896-11.patch. Unable to apply patch. See the log in the details link for more information.View details | Re-test

#12

Status:needs review» needs work

The last submitted patch, drupal-1825896-11.patch, failed testing.

#13

Status:needs work» needs review

#11: drupal-1825896-11.patch queued for re-testing.

#14

Status:needs review» needs work

The last submitted patch, drupal-1825896-11.patch, failed testing.

#15

Status:needs work» needs review

Yet another one.

AttachmentSizeStatusTest resultOperations
drupal-1825896-15.patch95.98 KBIdleFAILED: [[SimpleTest]]: [MySQL] 54,481 pass(es), 5 fail(s), and 0 exception(s).View details | Re-test

#16

Status:needs review» needs work

The last submitted patch, drupal-1825896-15.patch, failed testing.

#17

Status:needs work» needs review

It's great to see that our test coverage works properly.

AttachmentSizeStatusTest resultOperations
drupal-1825896-17.patch96.62 KBIdlePASSED: [[SimpleTest]]: [MySQL] 54,402 pass(es).View details | Re-test
interdiff.txt2.74 KBIgnoredNoneNone

#18

Status:needs review» needs work

The last submitted patch, drupal-1825896-17.patch, failed testing.

#19

Status:needs work» needs review

#17: drupal-1825896-17.patch queued for re-testing.