modules.feature file needs to be renamed to downloads_modules.feature and tests need to be expanded to:

- navigate Home page -> D&E -> Modules tab +
- check that page exists by some texts +
- check that filtering works should go to solr tests

ToDo:
This file needs 2 additional checks - to see if there are at least 4 links under "New Modules" and "Module Index".

Comments

eliza411’s picture

Module filter tests are in the solr folder. They probably need to be expanded. I am unsure how closely related the current test and this test will be.

Search:
http://drupal.org/search/site/views?f[0]=ss_meta_type%3Amodule

Modules tab:
http://drupal.org/project/modules/?f[0]=bs_project_sandbox%3A0

The filters are slow tests so we should try to avoid as much duplication as possible. Again, it's really hard to determine what behavior is expected for the filters - when that gets clarified, expanding the test should be fairly straightforward.

tvn’s picture

Issue tags: +search

It makes sense to me to keep all search-related tests in solr folder. Let's not include them in this file.

I'll tag this issue with "search" and get back to it when looking on solr tests.

tvn’s picture

Status: Active » Needs review

http://drupalcode.org/project/doobie.git/commit/05aedab

I've renamed the file and moved all modules-related tests from download.feature here.
Also added 1 scenario requested in this issue, to check that page exists.

I moved 2 scenarios which filter modules lists into downloads_search.feature. I'm wondering maybe it's better to move them to the solr tests as well?

This file needs 2 additional checks - to see if there are at least 4 links under "New Modules" and "Module Index".

kssundar’s picture

Assigned: Unassigned » kssundar
Status: Needs review » Needs work
Issue tags: +sprint 15

Failing scenarios:

@slow @timeout
Scenario: View most installed modules                            # features\drupalorg\downloads_modules.feature:8
  Given I am on the homepage                                     # FeatureContext::thatIAmOnTheHomepage()
  When I follow "Download and Extend"                            # FeatureContext::clickLink()
  Then I should see the following <links> under "Most installed" # FeatureContext::iShouldSeeTheFollowingLinksUnder()
    | links    |
    | Views    |
    | Token    |
    | Pathauto |
  And I should see at least "4" most installed modules           # FeatureContext::iShouldSeeAtLeastMostInstalledModules()
    The most installed block did not contain any links

And consistent timeout:

Scenario: View full modules index              # features\drupalorg\downloads_modules.feature:50
  Given I am on "/download"                    # FeatureContext::visit()
  And I follow "View full index"               # FeatureContext::clickLink()
    [curl] 28: Operation timed out after 30093 milliseconds with 34788 out of 192379 bytes received [url] http://drupal.org/project/modules/index [info] a
ay (
      'url' => 'http://drupal.org/project/modules/index',
      'content_type' => 'text/html; charset=utf-8',
      'http_code' => 200,
      'header_size' => 492,
      'request_size' => 215,
      'filetime' => -1,
      'ssl_verify_result' => 0,
      'redirect_count' => 0,
      'total_time' => 29.999,
      'namelookup_time' => 0,
      'connect_time' => 4.212,
      'pretransfer_time' => 4.212,
      'size_upload' => 0,
      'size_download' => 34788,
      'speed_download' => 1159,
      'speed_upload' => 0,
      'download_content_length' => 192379,
      'upload_content_length' => 0,
      'starttransfer_time' => 9.064,
      'redirect_time' => 0,
      'certinfo' =>
      array (
      ),
      'redirect_url' => '',
    ) [debug]
  Then I should be on "/project/modules/index" # FeatureContext::assertPageAddress()
  And I should see the heading "Modules index" # FeatureContext::iShouldSeeTheHeading()
  And I should see "Views"                     # FeatureContext::assertPageContainsText()
  And I should see "Link"                      # FeatureContext::assertPageContainsText()
kssundar’s picture

Status: Needs work » Needs review

For The most installed block did not contain any links exception, I found that the div ID attribute was changed from "block-drupalorg_order_facet-sort_most_installed" to "block-drupalorg_order_facet-iss_project_release_usage". I am not able to test this functionality because of the n/w connection issue here. Please verify. The commit is made here - http://drupalcode.org/project/doobie.git/commit/7be5dff

I am getting timeout for this scenario Scenario: View full modules index # features\drupalorg\downloads_modules.feature:50 always because our n/w connection suddenly has become very slow. Could anyone please verify this? Note that the modules index page is very long and it does take more time. If timeout occurs always then we can remove this scenario.

kssundar’s picture

tvn’s picture

Some more corrections to indentation: http://drupalcode.org/project/doobie.git/commit/b4cc254

tvn’s picture

Issue summary: View changes

.

eliza411’s picture

Status: Needs review » Reviewed & tested by the community

I updated the last few scenarios to contain the When statement in http://drupalcode.org/project/doobie.git/commit/665bc94

I think this one is good to go. tvn, if it's complete, remove the @wip tag and mark this fixed.

tvn’s picture

Status: Reviewed & tested by the community » Needs work

This file needs 2 more tests - to check that there are at least 4 links under "New Modules" and "Module Index". I was not sure if new function needs to be written for this or something can be re-used, so left for someone else to implement.

kssundar’s picture

Title: Update modules.feature file » Update downloads_modules.feature file
Status: Needs work » Needs review

Updated the feature accordingly and committed here - http://drupalcode.org/project/doobie.git/commit/5fff9e0

The first scenario is really slow and hence only one action is performed.

kssundar’s picture

eliza411’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

Looks as close as we'll get it until D7 Drupal.org is ready for feedback.

eliza411’s picture

Status: Reviewed & tested by the community » Closed (fixed)

Updated for D7

eliza411’s picture

Issue summary: View changes

.