Closed (fixed)
Project:
Drupal.org BDD
Version:
7.x-1.x-dev
Component:
Feature/Scenarios
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
29 Oct 2012 at 16:02 UTC
Updated:
19 Jul 2013 at 18:45 UTC
modules.feature file needs to be renamed to downloads_modules.feature and tests need to be expanded to:
- navigate Home page -> D&E -> Modules tab +
- check that page exists by some texts +
- check that filtering works should go to solr tests
ToDo:
This file needs 2 additional checks - to see if there are at least 4 links under "New Modules" and "Module Index".
Comments
Comment #2
eliza411 commentedModule filter tests are in the solr folder. They probably need to be expanded. I am unsure how closely related the current test and this test will be.
Search:
http://drupal.org/search/site/views?f[0]=ss_meta_type%3Amodule
Modules tab:
http://drupal.org/project/modules/?f[0]=bs_project_sandbox%3A0
The filters are slow tests so we should try to avoid as much duplication as possible. Again, it's really hard to determine what behavior is expected for the filters - when that gets clarified, expanding the test should be fairly straightforward.
Comment #3
tvn commentedIt makes sense to me to keep all search-related tests in solr folder. Let's not include them in this file.
I'll tag this issue with "search" and get back to it when looking on solr tests.
Comment #4
tvn commentedhttp://drupalcode.org/project/doobie.git/commit/05aedab
I've renamed the file and moved all modules-related tests from download.feature here.
Also added 1 scenario requested in this issue, to check that page exists.
I moved 2 scenarios which filter modules lists into downloads_search.feature. I'm wondering maybe it's better to move them to the solr tests as well?
This file needs 2 additional checks - to see if there are at least 4 links under "New Modules" and "Module Index".
Comment #5
kssundar commentedFailing scenarios:
And consistent timeout:
Comment #6
kssundar commentedFor
The most installed block did not contain any linksexception, I found that the div ID attribute was changed from "block-drupalorg_order_facet-sort_most_installed" to "block-drupalorg_order_facet-iss_project_release_usage". I am not able to test this functionality because of the n/w connection issue here. Please verify. The commit is made here - http://drupalcode.org/project/doobie.git/commit/7be5dffI am getting timeout for this scenario
Scenario: View full modules index # features\drupalorg\downloads_modules.feature:50always because our n/w connection suddenly has become very slow. Could anyone please verify this? Note that the modules index page is very long and it does take more time. If timeout occurs always then we can remove this scenario.Comment #7
kssundar commentedUpdated indentation - http://drupalcode.org/project/doobie.git/commit/e41889d
Comment #8
tvn commentedSome more corrections to indentation: http://drupalcode.org/project/doobie.git/commit/b4cc254
Comment #8.0
tvn commented.
Comment #9
eliza411 commentedI updated the last few scenarios to contain the When statement in http://drupalcode.org/project/doobie.git/commit/665bc94
I think this one is good to go. tvn, if it's complete, remove the @wip tag and mark this fixed.
Comment #10
tvn commentedThis file needs 2 more tests - to check that there are at least 4 links under "New Modules" and "Module Index". I was not sure if new function needs to be written for this or something can be re-used, so left for someone else to implement.
Comment #11
kssundar commentedUpdated the feature accordingly and committed here - http://drupalcode.org/project/doobie.git/commit/5fff9e0
The first scenario is really slow and hence only one action is performed.
Comment #12
kssundar commentedThis is ported to 7.x as well - http://drupalcode.org/project/doobie.git/commit/d340494
Comment #13
eliza411 commentedLooks as close as we'll get it until D7 Drupal.org is ready for feedback.
Comment #14
eliza411 commentedUpdated for D7
Comment #14.0
eliza411 commented.