The tests should go into downloads_themes.feature and check:

- navigate Home page -> D&E -> Themes tab
- check that page exists and block in the sidebar shows up
- check that filtering works not in this file

Comments

eliza411’s picture

It would be really helpful on these to start out a test request with the actual feature description and business value.

eliza411’s picture

Maybe something like:

Feature: Find Drupal themes
  In order to make my site visually distinct from other sites
  as a site builder
  I need to be able to browse available themes

The themes filters should get matrixed into the solr tests and tagged @downloads, which I think concentrate exclusively on solr searches narrowed by the Modules facet. Since the Solr 6.x-3.x deployment on Saturday, the search results appear somewhat less focused than previously, and I'd be inclined to postpone this (or at least the filter portion) until we have results that feel solid.

tvn’s picture

Status: Active » Needs review

I've added the file (http://drupalcode.org/project/doobie.git/commit/05aedab)

For now I added tests to just check if pages like "New Themes" show at least some distributions. Later we might expand them to check if they really show new ones.

Filters tests should go to the solr folder with the rest, so not into this file.

eliza411’s picture

Status: Needs review » Needs work

Mostly looking good. A couple of details: most of these are missing the When statement and a few steps are indented too far.

 Scenario: Visit Themes page
    Given I am on "/download"
    And I follow "Themes"
    Then I should be on "/project/themes"
    And I should see the following <tabs>

should be

 Scenario: Visit Themes page
    Given I am on "/download" <- puts system in a known state
    When I follow "Themes" <- user action which changes the state
    Then I should be on "/project/themes" <- expected behavior based on user action
    And I should see the following <tabs>
    And I should see that the tab "Themes" is highlighted
    And I should see "Themes match your search"
    And I should see "Themes allow you to change the look and feel of your Drupal site"
    And I should see "Posted by"
        And I should see the heading "Drupal Themes"
        And I should see "Theme guide"
        And I should see "More advanced themes are table-less"

Should be

    And I should see that the tab "Themes" is highlighted
    And I should see "Themes match your search"
    And I should see "Themes allow you to change the look and feel of your Drupal site"
    And I should see "Posted by"
    And I should see the heading "Drupal Themes"
    And I should see "Theme guide"
    And I should see "More advanced themes are table-less"
kssundar’s picture

Status: Needs work » Needs review

I think the first 4 scenarios can be put under "Scenario Outline" and something like this:

  Scenario Outline: Visit links releated to themes
      Given I am on "/download"
      When I follow "<link>"
      Then I should see "<text1>"
      And I should see "<text2>"

      Examples:
      | link                     | text1                    | text2                               |
      | About Themes & Subthemes | About theming            | You can do more with a theme        |
      | Most Installed Themes    | Themes match your search | Themes allow you to change the look |
      | New Themes               | Filter by compatibility  | Status                              |
      | Most Active Themes       | Search Themes            | Posted by                           |

Any thoughts?

tvn’s picture

Fixed When statements and indentation (sorry about that!)
http://drupalcode.org/project/doobie.git/commit/e2a37d9

Re: #5 most of those scenarios have 3 texts so there will be 4 columns. I am not sure it will be too convenient. If you think it's better though I don't mind, as long as we keep all the texts.

kssundar’s picture

Issue tags: +sprint 15

Updated feature - http://drupalcode.org/project/doobie.git/commit/0cf3db6

Made minor modification to the above scenario outline.

eliza411’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Removed the @wip tag. This is ready to pull to 7.x

kssundar’s picture

Status: Patch (to be ported) » Needs review
kssundar’s picture

Title: Create tests for /downloads/themes » Create tests for /downloads/themes (downloads_themes.feature)

Adjusting title

eliza411’s picture

Status: Needs review » Fixed

Great, marking fixed. Will get a final update as part of the featureset review.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

.