The tests should go into downloads_themes.feature and check:
- navigate Home page -> D&E -> Themes tab
- check that page exists and block in the sidebar shows up
- check that filtering works not in this file
The tests should go into downloads_themes.feature and check:
- navigate Home page -> D&E -> Themes tab
- check that page exists and block in the sidebar shows up
- check that filtering works not in this file
Comments
Comment #1
eliza411 commentedIt would be really helpful on these to start out a test request with the actual feature description and business value.
Comment #2
eliza411 commentedMaybe something like:
The themes filters should get matrixed into the solr tests and tagged @downloads, which I think concentrate exclusively on solr searches narrowed by the Modules facet. Since the Solr 6.x-3.x deployment on Saturday, the search results appear somewhat less focused than previously, and I'd be inclined to postpone this (or at least the filter portion) until we have results that feel solid.
Comment #3
tvn commentedI've added the file (http://drupalcode.org/project/doobie.git/commit/05aedab)
For now I added tests to just check if pages like "New Themes" show at least some distributions. Later we might expand them to check if they really show new ones.
Filters tests should go to the solr folder with the rest, so not into this file.
Comment #4
eliza411 commentedMostly looking good. A couple of details: most of these are missing the When statement and a few steps are indented too far.
should be
Should be
Comment #5
kssundar commentedI think the first 4 scenarios can be put under "Scenario Outline" and something like this:
Any thoughts?
Comment #6
tvn commentedFixed When statements and indentation (sorry about that!)
http://drupalcode.org/project/doobie.git/commit/e2a37d9
Re: #5 most of those scenarios have 3 texts so there will be 4 columns. I am not sure it will be too convenient. If you think it's better though I don't mind, as long as we keep all the texts.
Comment #7
kssundar commentedUpdated feature - http://drupalcode.org/project/doobie.git/commit/0cf3db6
Made minor modification to the above scenario outline.
Comment #8
eliza411 commentedRemoved the @wip tag. This is ready to pull to 7.x
Comment #9
kssundar commentedPorted to 7.x - http://drupalcode.org/project/doobie.git/commit/945b5f3
Comment #10
kssundar commentedAdjusting title
Comment #11
eliza411 commentedGreat, marking fixed. Will get a final update as part of the featureset review.
Comment #12.0
(not verified) commented.