Remove dead mac_key variable from open_id_test module

You need to set the mac_key in openid_test.install

+++ b/core/modules/openid/lib/Drupal/openid/Tests/OpenIDFunctionalTest.phpundefined
@@ -362,7 +362,7 @@ function testSignatureValidation() {
+    $association->mac_key = state()->get('mac_key') ?: FALSE;

There's no point doing the conditional here... should just be $association->mac_key = state()->get('mac_key');

Also the state key should be namespaced... so it should be openid_test.mac_key

It's interesting that the tests works without a mac_key... this should be investigated too.

I replaced the state key.

What should I do to investigate the testing issue?

I had the wrong Git config...

The tests seem to be broken. Initially there were thwo variable names mac_key and openid_test_mac_key. And we are converting both of them to openid_test.mac_key. Is this correct? Also, We are not converting a set. This can't have the correct result in the tests.

Looks good to me!

Lets not perpetuate this bug...

+++ b/core/modules/openid/tests/openid_test.installundefined
@@ -13,5 +13,5 @@ function openid_test_install() {
// Generate a MAC key (Message Authentication Code) used for signing messages.
// The variable is base64-encoded, because variables cannot contain non-UTF-8
// data.
- variable_set('openid_test_mac_key', base64_encode(_openid_get_bytes(20)));
+ state()->set('openid_test_mac_key', base64_encode(_openid_get_bytes(20)));

The .install file and variable/state key is completely unnecessary as it is in never actually used!

How about this patch...

Taking code out is always better than putting code in :)

Heh nice find, let's kill it. Committed/pushed to 8.x.