Download & Extend
Views » Issues

Place dropbutton operations after their heading

Posted by falcon03 on October 29, 2012 at 8:14pm
Project:Views
Version:7.x-3.x-dev
Component:User interface
Category:task
Priority:normal
Assigned:Unassigned
Status:needs review
Issue tags:a11ySprint, accessibility, needs backport to D7

Issue Summary

When adding a view, a blind user can see "fields", "sort criteria", "filter criteria" and similar titles as headings. But, unfortunately, the related operations are shown before the headings, not after them. This is really confusing for new views user (it was one of my main issues with views) and increases very much the learning curve for new blind users.

Just to clarify, let me give an example of the structure that I would like to see (related to sort criteria):

  1. The "sort criteria" heading;
  2. The sort criteria that a view is currently using;
  3. The dropbutton to add a new sort criteria
Login or register to post comments

Comments

#1

Posted by falcon03 on October 29, 2012 at 9:37pm
Title:Place dropbutton operations after thier heading» Place dropbutton operations after their heading

Correcting title.

#2

Posted by dawehner on October 30, 2012 at 8:45pm
Priority:major» normal
Issue tags:+VDC

Compared to #1824634: [meta] Dropbutton accessibility issues this should be normal

#3

Posted by Bojhan on November 4, 2012 at 9:30am

Isnt this like a novice task?

This one is borderline major, I actually did the whole NVDA thing with your eyes closed. And this one is really confusing.

#4

Posted by larowlan on November 6, 2012 at 10:00pm
Status:active» needs review

Straight forward re-ordering of markup, screenshots attached.
Before
Screen Shot 2012-11-07 at 7.58.01 AM.png
After
Screen Shot 2012-11-07 at 7.58.23 AM.png

AttachmentSizeStatusTest resultOperations
dropbutton-views-1826368.4.patch695 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 47,818 pass(es).View details | Re-test
Screen Shot 2012-11-07 at 7.58.01 AM.png22.51 KBIgnoredNoneNone
Screen Shot 2012-11-07 at 7.58.23 AM.png22.71 KBIgnoredNoneNone

#5

Posted by cbiggins on November 6, 2012 at 11:11pm
Status:needs review» reviewed & tested by the community

Looks good. Patch applied and screen read with VoiceOver.

#6

Posted by larowlan on November 6, 2012 at 11:15pm
Status:reviewed & tested by the community» needs review

works ok in voiceover/chrome/osx now

#7

Posted by larowlan on November 6, 2012 at 11:28pm
Status:needs review» reviewed & tested by the community

cross post

#8

Posted by dawehner on November 7, 2012 at 10:14am

Nice work!

#9

Posted by webchick on November 7, 2012 at 12:47pm
Status:reviewed & tested by the community» fixed

Committed and pushed to 8.x. Rock!

#10

Posted by falcon03 on November 8, 2012 at 8:17pm
Status:fixed» active

Sorry, I haven't had time to test the patch these days, I've been able to test it only today.

Things are better now. But I think that things related to the dropbutton should be placed between the heading and the dropbutton itself.

For instance, for the "sort criteria" the structure should be the one described in the issue summary. Actually, instead, it is as follows:

  1. the "sort criteria" heading;
  2. the dropbutton to add a new sort criteria
  3. The sort criteria that a view is currently using

I am re-opening this issue; I don't know if this should be a follow up.

#11

Posted by mgifford on November 16, 2012 at 11:14am
Issue tags:+a11ySprint

Hopefully we can sort through this in the issue and make a revision.

#12

Posted by Yoshi on November 18, 2012 at 10:17pm
Status:active» needs review

Moved the $content above the $actions. Seems to work.

AttachmentSizeStatusTest resultOperations
dropbutton-views-1826368-12.patch592 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 48,214 pass(es).View details | Re-test

#13

Posted by dawehner on November 19, 2012 at 9:18am

This looks good from the code site, but i'm wondering whether the visual output changes with that change? Maybe someone
should just post a screenshot.

#14

Posted by falcon03 on November 19, 2012 at 11:14am

From the accessibility point of view it's perfect now. RTBC for me, but I am not changing the status due to dawehner request.

BTW: With the two small fixes in this issue we made two very big improvements to views accessibility! The placement of operations was really difficult to understand for new views blind users...

#15

Posted by dawehner on November 19, 2012 at 6:11pm
Status:needs review» reviewed & tested by the community

So there is no visual difference before and after this change, it looks perfect!

Before

before.png

After

after.png

AttachmentSizeStatusTest resultOperations
after.png4.95 KBIgnoredNoneNone
before.png5.13 KBIgnoredNoneNone

#16

Posted by Dries on November 20, 2012 at 2:26am
Status:reviewed & tested by the community» fixed

Thanks! Committed to 8.x.

#17

Posted by dawehner on November 20, 2012 at 10:20am
Project:Drupal core» Views
Version:8.x-dev» 7.x-3.x-dev
Component:views_ui.module» User interface
Status:fixed» active
Issue tags:+Novice

Let's backport that.

#18

Posted by IshaDakota on November 23, 2012 at 2:03pm
Status:active» needs review

patch for backport to D7

AttachmentSizeStatusTest resultOperations
views-dropbutton-d7port-1826368-18.patch674 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 1,603 pass(es).View details | Re-test

#19

Posted by IshaDakota on November 23, 2012 at 2:06pm

oops, whitespace removed.

AttachmentSizeStatusTest resultOperations
views-dropbutton-d7port-1826368-19.patch672 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 1,603 pass(es).View details | Re-test

#20

Posted by IshaDakota on November 23, 2012 at 2:37pm

Screenshot before patch applied:
dropbuttond7port-before.png

Screenshot after patch applied:
dropbuttond7port-after.png

Appears visually unaltered.

AttachmentSizeStatusTest resultOperations
dropbuttond7port-after.png19.62 KBIgnoredNoneNone
dropbuttond7port-before.png19.88 KBIgnoredNoneNone

#21

Posted by dawehner on November 23, 2012 at 2:39pm
Status:needs review» reviewed & tested by the community

That is looking great!

#22

Posted by falcon03 on November 24, 2012 at 9:02pm
Project:Views» Drupal core
Version:7.x-3.x-dev» 8.x-dev
Component:User interface» views_ui.module
Status:reviewed & tested by the community» needs work

Guys, I don't know what happened. We have a problem: I don't know the reason why, but the situation at this time is the same as in #10...

I am sorry this issue is becoming confused, but I thought I'd better report the problem here.

#23

Posted by dawehner on November 26, 2012 at 9:35am

Well i have no clue why, but the HTML is fine.

#24

Posted by mgifford on January 30, 2013 at 6:01pm
Status:needs work» needs review

#19: views-dropbutton-d7port-1826368-19.patch queued for re-testing.

#25

Posted by System Message on January 30, 2013 at 6:21pm
Status:needs review» needs work

The last submitted patch, views-dropbutton-d7port-1826368-19.patch, failed testing.

#26

Posted by EllaTheHarpy on January 31, 2013 at 2:59am

I looked for the file mentioned in #12, that it sounds like Dries committed in #16.
It looks like it should have been in this file core/modules/views/views_ui/theme/views-ui-display-tab-bucket.tpl.php.
but, there is no theme directory in views_ui.

Where is this file now?

#27

Posted by tim.plunkett on January 31, 2013 at 3:04am

It was moved in #1805980: Rename /theme to /templates and theme.inc to views.theme.inc to core/modules/views/views_ui/templates/views-ui-display-tab-bucket.tpl.php

#28

Posted by mgifford on January 31, 2013 at 4:22am
Issue tags:-Novice, -VDC

@EllaTheHarpy are you able to reroll a new patch?

#29

Posted by mgifford on February 1, 2013 at 4:09am

I think the patch from #19 got it into core. From core/modules/views/views_ui/templates/views-ui-display-tab-bucket.tpl.php the HTML now looks like:

<div <?php print $attributes; ?>>
  <?php if (!empty($title)) : ?>
    <h3><?php print $title; ?></h3>
  <?php endif; ?>
  <?php print $content; ?>
  <?php if (!empty($actions)) : ?>
    <?php print $actions; ?>
  <?php endif; ?>
</div>

Now whether it is working properly or not is another issue, but it should be in the right order now.

#30

Posted by dawehner on February 1, 2013 at 1:17pm

So this should be marked as fixed?

#31

Posted by mgifford on February 1, 2013 at 1:47pm
Status:needs work» fixed

Yes, it seems to be. Attached a screenshot. HTML looks good. VoiceOver approaches this in the right order.

AttachmentSizeStatusTest resultOperations
SortOrder.png257.89 KBIgnoredNoneNone

#32

Posted by IshaDakota on February 1, 2013 at 8:06pm
Project:Drupal core» Views
Version:8.x-dev» 7.x-3.x-dev
Component:views_ui.module» User interface
Status:fixed» needs review

The patch in #19 was a backport against Views-7.x-3.x. The patch in #12 was committed to core.

Changing the project and status in case backport is still needed/wanted.

#33

Posted by IshaDakota on February 1, 2013 at 8:06pm

#19: views-dropbutton-d7port-1826368-19.patch queued for re-testing.