Place dropbutton operations after their heading

Compared to #1824634: [meta] Dropbutton accessibility issues this should be normal

Isnt this like a novice task?

This one is borderline major, I actually did the whole NVDA thing with your eyes closed. And this one is really confusing.

Straight forward re-ordering of markup, screenshots attached.
Before

After

Looks good. Patch applied and screen read with VoiceOver.

works ok in voiceover/chrome/osx now

cross post

Nice work!

Committed and pushed to 8.x. Rock!

Hopefully we can sort through this in the issue and make a revision.

Moved the $content above the $actions. Seems to work.

This looks good from the code site, but i'm wondering whether the visual output changes with that change? Maybe someone
should just post a screenshot.

So there is no visual difference before and after this change, it looks perfect!

Before

After

Thanks! Committed to 8.x.

Let's backport that.

patch for backport to D7

oops, whitespace removed.

Screenshot before patch applied:

Screenshot after patch applied:

Appears visually unaltered.

That is looking great!

Well i have no clue why, but the HTML is fine.

#19: views-dropbutton-d7port-1826368-19.patch queued for re-testing.

I looked for the file mentioned in #12, that it sounds like Dries committed in #16.
It looks like it should have been in this file core/modules/views/views_ui/theme/views-ui-display-tab-bucket.tpl.php.
but, there is no theme directory in views_ui.

Where is this file now?

It was moved in #1805980: Rename /theme to /templates and theme.inc to views.theme.inc to core/modules/views/views_ui/templates/views-ui-display-tab-bucket.tpl.php

@EllaTheHarpy are you able to reroll a new patch?

I think the patch from #19 got it into core. From core/modules/views/views_ui/templates/views-ui-display-tab-bucket.tpl.php the HTML now looks like:

<div <?php print $attributes; ?>>
  <?php if (!empty($title)) : ?>
    <h3><?php print $title; ?></h3>
  <?php endif; ?>
  <?php print $content; ?>
  <?php if (!empty($actions)) : ?>
    <?php print $actions; ?>
  <?php endif; ?>
</div>

Now whether it is working properly or not is another issue, but it should be in the right order now.

So this should be marked as fixed?

Yes, it seems to be. Attached a screenshot. HTML looks good. VoiceOver approaches this in the right order.

The patch in #19 was a backport against Views-7.x-3.x. The patch in #12 was committed to core.

Changing the project and status in case backport is still needed/wanted.

#19: views-dropbutton-d7port-1826368-19.patch queued for re-testing.

The 6 year old patch in #19 to views-ui-display-tab-bucket.tpl.php does not apply to the latest views 7.x-3.x-dev and if still applicable needs to be rerolled.

Checking patch theme/views-ui-display-tab-bucket.tpl.php...
error: while searching for:
?>
<div class="<?php print $classes; ?>" <?php print $attributes; ?>>
  <?php print $item_help_icon; ?>
  <?php if(!empty($actions)) : ?>
    <?php print $actions; ?>
  <?php endif; ?>
  <?php if (!empty($title)) : ?>
    <h3><?php print $title; ?></h3>
  <?php endif; ?>
  <?php print $content; ?>
</div>

error: patch failed: theme/views-ui-display-tab-bucket.tpl.php:7
error: theme/views-ui-display-tab-bucket.tpl.php: patch does not apply

Patch rerolled.