'Reset vote' link in comments disappears when the widget is disabled

Nall - October 11, 2007 - 14:55
Project:Vote Up/Down Package
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:frjo
Status:closed
Description

I'm working around vote_up_down to hook a link into $links instead of using the widgets. However, I noticed when the comment widget was disabled, the comment 'reset vote' link disappeared too.

Thought it was a bug; peeked at the code. I considered that this might have been by design, since if vote reset is enabled, that link wouldn't disappear at all otherwise, even if voting wasn't desired on comments. But it seems to me it'd be better if it disappeared when both widget and vote total display are disabled; here's a quick patch doing just that.

AttachmentSize
vote_up_down.module-resetlink.patch907 bytes

#1

awong - December 12, 2007 - 00:02

The patch is working. I think it is a good idea to do that, then you have control on the link and widget

#2

frjo - December 13, 2007 - 08:53
Assigned to:Anonymous» frjo
Status:patch (code needs review)» fixed

Works for me also. Committed to 5-dev. Thanks for the patch Nall.

#3

Anonymous - December 27, 2007 - 09:34
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.